Add asciidoc module #102
Add asciidoc module #102
Conversation
|
|
||
| public String apply(String asciidoc) { | ||
| Document document = parser.parse(asciidoc, new Parser.ParserContext(null)); | ||
| AsciidoctorLikeHtmlRenderer renderer = new AsciidoctorLikeHtmlRenderer(new AsciidoctorLikeHtmlRenderer.Configuration() |
There was a problem hiding this comment.
The renderer could be re-used for multiple files right?
There was a problem hiding this comment.
The renderer could be re-used for multiple files right?
In that case, both Parser and AsciidoctorLikeHtmlRenderer should be thread-safe. Is that so?
asciidoc/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
|
@mcruzdev any progress on this? |
|
Hi @ia3andy, I'm resuming this now. |
|
@mcruzdev whats the dfiference in html you were concerned about ? |
...test/java/io/quarkiverse/qute/web/asciidoc/test/QuteAsciidocSectionWithInnerSectionTest.java
Outdated
Show resolved
Hide resolved
...yment/src/test/java/io/quarkiverse/qute/web/asciidoc/test/QuteAsciidocSectionHelperTest.java
Outdated
Show resolved
Hide resolved
@maxandersen, this library generates different semantic HTML tags compared to CommonMark. We need to submit some pull requests to the yupiik/tools-maven-plugin repository to ensure the behavior is as expected. While this isn’t an issue for standalone use, it can (we need to test) affect CSS application when used with Roq. |
|
@mkouba you have the final word.. |
...idoc/deployment/src/test/java/io/quarkiverse/qute/web/asciidoc/test/QuarkusAsciidocTest.java
Outdated
Show resolved
Hide resolved
...yment/src/test/java/io/quarkiverse/qute/web/asciidoc/test/QuteAsciidocSectionHelperTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/quarkiverse/qute/web/asciidoc/test/QuteAsciidocSectionWithInnerSectionTest.java
Outdated
Show resolved
Hide resolved
asciidoc/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
asciidoc/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
Fix quarkiverse#66: RoqCollection by and group helpers
mcruzdev
force-pushed
the
issue-95
branch
2 times, most recently
from
4b5778e
to
0e37a97
Compare
|
@mcruzdev thanks! |
Fixes #95