sse: introduce dummy init in the dev mode #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if an MCP client attempts to reconnect an SSE connection but does not reinitialize propertly, we could perform a "dummy" initialization
mkouba
force-pushed
the
dev-mode-dummy-init
branch
from
c32230b to
337bfa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not fix #102 because when the app is restarted, the HTTP SSE connection is closed and there's not much we can do about it. However, some MCP clients (such as MCP Inspector) do attempt to reconnect but do not reinitialize MCP properly. With this change, we perform a "dummy" initialization when needed and so the subsequent requests can be processed as normally.
CC @maxandersen @sebastienblanc