Draft
Conversation
This change adds a new test file `qsimcirq_tests/add_op_to_circuit_test.py` to improve the test coverage of the `add_op_to_circuit` function in `qsimcirq/qsim_circuit.py`. The following edge cases and scenarios are now covered: - Controlled gates with more than 4 target qubits (raises `NotImplementedError`). - Gates with non-numeric parameters (raises `ValueError`). - Diagonal gates (2-qubit and 3-qubit) for both noiseless and noisy circuits. - Matrix gates for both noiseless and noisy circuits. - Early return when controlled gate details are invalid. Due to the restricted environment missing `cirq`, `numpy`, and the `qsim` extension, these tests use a robust mocking strategy to verify the internal logic of the translation function. Additionally, applied project formatting standards using `./check/format-incremental --apply`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new test file
qsimcirq_tests/add_op_to_circuit_test.pyto improve the test coverage of theadd_op_to_circuitfunction inqsimcirq/qsim_circuit.py.The following edge cases and scenarios are now covered:
NotImplementedError).ValueError).Due to the restricted environment missing
cirq,numpy, and theqsimextension, these tests use a robust mocking strategy to verify the internal logic of the translation function.Additionally, applied project formatting standards using
./check/format-incremental --apply.