Add XETR as a separate market. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #129. XFRA and XETR, while both part of Deutsche Börse AG, are actually two different markets represented by different operating MICs. They largely share the same properties, but exchange hours are different.
This PR is to add a separate calendar for XETR.
Compared to XFRA, I've adjusted the early close time to 14:00 CET (was 12:30 for XFRA, not entirely sure this is actually correct). Everything else already seemed to be consistent.
I've added a note in the code that the early close day towards the end of the year is decided upon separately each year in December. So, having a rule for this is basically just a working assumption of what will happen in the future as well.
With this merged in, XFRA could be adjusted independently if, according to #129, exchange times are indeed incorrect there.