BLD: Add test to extras_require
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closses #143. Ideally we'd change etc/requirements.txt to a lock file and use that as a constraint to install the `extras_require` in the GHA step.
richafrank
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Nice @gerrymanoim . I was looking at the requirements.txt to compare to what we have in install_reqs and this test extra, and I notice that these are in neither list:
configparser==3.5.0
enum34==1.1.6
python-dateutil==2.7.3
six==1.11.0
Are they transitive dependencies?
I was thinking about how it would be nice not to maintain reqs.txt in addition to the two lists in setup.py. Maybe we should make that a pip-compile generated file, which would also answer my first question. Then our CI could install -e .[test] -c constraints_file and actually exercise this new feature.
This looks good though.
beppe712
pushed a commit
to AlpacaTechJP/trading_calendars
that referenced
this pull request
Dec 26, 2022
…actions/actions/setup-python-2.3.2 Bump actions/setup-python from 2.3.1 to 2.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143.
Ideally we'd change etc/requirements.txt to a lock file and use that as a constraint to install the
extras_requirein the GHA step.