Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests_require to setup.py #143

Closed
leonarduschen opened this issue Aug 30, 2020 · 1 comment · Fixed by #144
Closed

Add tests_require to setup.py #143

leonarduschen opened this issue Aug 30, 2020 · 1 comment · Fixed by #144

Comments

@leonarduschen
Copy link
Contributor

This is a follow up to #113

Setting up the required packages to run the tests for the first time was a hassle for me. It's probably a good idea to add test dependencies to setup.py to make it easier for us to contribute.

Dependencies:
nose
nose-ignore-docstring
nose-timer
nose-parameterized
@gerrymanoim
Copy link
Collaborator

Currently we install from the requirements file at https://github.com/quantopian/trading_calendars/blob/master/etc/requirements.txt (for example, the command in testing is here: https://github.com/quantopian/trading_calendars/blob/master/.github/workflows/main.yml#L42).

I agree that this should also live in an extras_require under test.

gerrymanoim pushed a commit that referenced this issue Aug 31, 2020
BLD: Add test to extras_require
020768d 
Closses #143.

Ideally we'd change etc/requirements.txt to a lock file and use that as a constraint to install the `extras_require` in the GHA step.
@gerrymanoim gerrymanoim mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BLD: Add test to extras_require quantopian/trading_calendars
2 participants
@gerrymanoim @leonarduschen