Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace virtualenv by python3 -m venv, fix #48 #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ PenguinDome also uses a bunch of Python packages, all of which are
deployed into a private virtualenv on the clients and server using
`pip` at install time.

`virtualenv` are created with native `python3 -m venv` tool now.
Existing `virtualenv` created previously with `virtualenv` continue
to work as-is.

The use of `netifaces` package in client plugins requires `pip`
to compile it, hence the requirement of ubuntu `python-dev` or
equivalent on *the client* side.

There's a nascent attempt in the `arch` subdirectory to build Pacman
client packages for Arch Linux, but these don't entirely work right
now, so for the time being, Arch clients use the same deployment
Expand Down
2 changes: 1 addition & 1 deletion client/arch-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ git
lvm2
psmisc
python
python-virtualenv
python
systemd
tar
util-linux
Expand Down
2 changes: 1 addition & 1 deletion client/client-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ elif [ "$ID_LIKE" = "archlinux" -o "$ID" = "arch" ]; then
fi

if [ ! -d $venv ]; then
virtualenv -p python3 $venv
python3 -m venv $venv
fi

for dir in $(find $venv -name site-packages); do
Expand Down
3 changes: 2 additions & 1 deletion client/ubuntu-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ systemd
tar
ubuntu-release-upgrader-core
update-notifier-common
virtualenv
python3-venv
python3-dev
wireless-tools
2 changes: 1 addition & 1 deletion server/arch-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ gnupg
https://aur.archlinux.org/libgfshare.git
openssl
python
python-virtualenv
python
systemd
tar
2 changes: 1 addition & 1 deletion server/server-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ elif [ "$ID_LIKE" = "archlinux" ]; then
fi

if [ ! -d $venv ]; then
virtualenv -p python3 $venv
python3 -m venv $venv
fi

for dir in $(find $venv -name site-packages); do
Expand Down
3 changes: 2 additions & 1 deletion server/ubuntu-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ openssl
python3
systemd
tar
virtualenv
python3-venv
python3-dev