Add tests #100
Open
Add tests #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-berchet
force-pushed
the
add_tests
branch
from
873569e to
6e3abcd
Compare
|
This PR also removes a useless (as far as I know) space in items. |
adrien-berchet
commented
Dec 23, 2022
| @@ -335,7 +335,7 @@ def convert_list(items, ids, parent, attr_type, item_func, cdata): | |||
|
|
|||
| elif isinstance(item, iterable): | |||
| if not attr_type: | |||
| addline('<%s %s>%s</%s>' % ( | |||
| addline('<%s%s>%s</%s>' % ( | |||
There was a problem hiding this comment.
This space is already generated by make_attrstring(attr)
|
This proposal is excellent and long overdue, and thank you for taking the time to prepare this pull request. I will review it at my earliest opportunity. |
|
Glad to help :) |
|
I just realized that this PR is still pending so let's revive it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest we add some automated tests in order to avoid unexpected breaking changes, as the one reported in #98 .
Depends on #99