Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra short string #120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Extra short string #120

wants to merge 5 commits into from

Conversation

mattenbergerp
Copy link

Semantic versioning

This PR is a Minor (non-breaking change, adds functionality or feature)

Generall things to consider

Notable changes

Strings usually have limits on APIs, databases, display or other.
This change is taking these practical limits into consideration by limiting them to a reasonable length.

Added

1 new simple type for extra short strings (up to 50 characters).

Changed

Replaced certain string type usages to extraShortString.

Copy link
Collaborator

@merrycoder merrycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants