Skip to content

Device Tree Changes for LT9611C#763

Open
mohitdsor wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mohitdsor:fix/my-second-change
Open

Device Tree Changes for LT9611C#763
mohitdsor wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mohitdsor:fix/my-second-change

Conversation

@mohitdsor

@mohitdsor mohitdsor commented Jun 23, 2026

Copy link
Copy Markdown

Device Tree Changes for LT9611C
CRs-Fixed: 4552827

@mohitdsor mohitdsor changed the base branch from main to qcom-6.18.y June 23, 2026 16:10
@mohitdsor mohitdsor requested review from a team, quic-kaushalk, quicAspratap and rrnayak June 23, 2026 16:10
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4552827 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4552827
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from 890eadc to ba35046 Compare June 23, 2026 21:01

@sgaud-quic sgaud-quic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post patch Upstream and bring as FROMLIST

@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from ba35046 to d088a35 Compare June 27, 2026 18:45
@qcomlnxci qcomlnxci requested a review from a team June 27, 2026 18:47
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
⚠️ 5 Full report

Final Summary

  1. Lore link present: Yes — valid lore.kernel.org URL with proper message-ID format
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable for comparison
  3. Upstream patch status: In review — PENDING: prefix indicates not yet merged; message-ID dated 2026-06-27 (4 days after patch authorship)
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #763 - PENDING: arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/ (cannot verify - network restricted)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore.kernel.org unreachable; PENDING: prefix indicates not yet merged
Body preserves rationale ⚠️ Minimal description; lacks detail on hardware configuration, pin assignments, or why changes are needed
Fixes tag present/correct N/A Not a fix; new hardware support
Authorship preserved Author: Mohit Dsor mohit.dsor@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport; PENDING: prefix indicates under review upstream

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Spaces instead of tabs in &pm8150_l11 block (lines 140-143); trailing blank lines at EOF

Issues

  • Whitespace: The &pm8150_l11 regulator block uses spaces for indentation instead of tabs (DTS convention requires tabs)
  • Trailing whitespace: Two blank lines added at end of file (line 180-181) instead of single newline
  • Commit message: Body is too terse; should explain what hardware is being enabled, why these specific regulators/pins are needed, and reference the bridge driver
  • Date mismatch: Patch authored June 23, lore message-id dated June 27 (v1-5 suggests part of series; date difference expected but worth noting)
  • PENDING prefix: Indicates patch not yet accepted upstream; appropriate for review but signals work-in-progress status

Verdict

Requires minor fixes before merge: correct indentation in &pm8150_l11 block (tabs not spaces), remove trailing blank lines, and optionally expand commit message body with hardware context.

Final Summary

  1. Lore link present: Yes — valid lore.kernel.org URL with proper message-ID format
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable for comparison
  3. Upstream patch status: In review — PENDING: prefix indicates not yet merged; message-ID dated 2026-06-27 (4 days after patch authorship)
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28298443164

Checker Result Summary
Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues + undocumented compatible
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Schema validation failure: lontium,lt9611uxd has no matching schema
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation: "PENDING:" not allowed
tag-check N/A Not applicable for this PR
qcom-next-check N/A Not applicable (PENDING prefix)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - PENDING: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28298443164

Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues + undocumented compatible
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Schema validation failure: lontium,lt9611uxd has no matching schema
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation: "PENDING:" not allowed
tag-check N/A Not applicable for this PR
qcom-next-check N/A Not applicable (PENDING prefix)

❌ checkpatch

Root cause: Mixed use of spaces instead of tabs for indentation in &pm8150_l11 node (lines 541-544), plus multiple blank lines and undocumented compatible string.

Failure details:

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented
#70: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:370:
+		compatible = "lontium,lt9611uxd";

CHECK: Please don't use multiple blank lines
#138: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:539:

ERROR: code indent should use tabs where possible
#140: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:541:
+        /* DSI VDDA - must be at NOM voltage for PHY PLL lock */

ERROR: code indent should use tabs where possible
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;

WARNING: please, no spaces at the start of a line
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;

ERROR: code indent should use tabs where possible
#142: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:543:
+        regulator-max-microvolt = <1232000>;

ERROR: code indent should use tabs where possible
#143: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:544:
+        regulator-allow-set-load;

CHECK: Please don't use multiple blank lines
#181: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:806:

Total: 4 errors, 4 warnings, 2 checks

Fix:

  1. Replace spaces with tabs in the &pm8150_l11 block (lines 541-544 in the patch)
  2. Remove extra blank lines at line 539 and line 806
  3. The undocumented compatible warning is expected if the binding hasn't been merged yet (see dtb-check below)

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..d088a35b9ce70817524a620fdadaea8fd1ebbd1b

❌ dtb-check

Root cause: The compatible string lontium,lt9611uxd has no matching device tree binding schema in Documentation/devicetree/bindings/.

Failure details:

arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: /soc@0/geniqup@4ac0000/i2c@4a90000/lt9611uxd@41: 
  failed to match any schema with compatible: ['lontium,lt9611uxd']

Fix:
This PR adds device tree nodes for the LT9611UXD HDMI-DSI bridge, but the corresponding device tree binding documentation is missing. You need to either:

  1. Add the binding first (recommended upstream approach):

    • Create Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml
    • Submit the binding as a separate patch before the DTS changes
    • Reference: The lore link in the commit message suggests this is part of a series
  2. Or verify the binding exists upstream:

    • Check if the binding was already merged in mainline
    • If yes, ensure your tree is rebased on a version that includes it

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb

❌ check-patch-compliance

Root cause: Commit subject starts with "PENDING:" which is not an allowed prefix for the Qualcomm Linux kernel tree.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: Shikra LT9611UXD support
Commit summary does not start with a required prefix

Fix:
Replace the "PENDING:" prefix with one of the allowed prefixes:

  • FROMLIST: - if the patch is posted to an upstream mailing list but not yet merged
  • UPSTREAM: - if the patch is already merged in mainline
  • BACKPORT: - if backporting from a newer kernel version
  • Or use the standard subsystem prefix: arm64: dts: qcom: shikra: Add LT9611UXD HDMI bridge support

Based on the lore link in the commit message (https://lore.kernel.org/all/20260627-shikra-dt-changes-v1-5-449a402673d0@oss.qualcomm.com/), this appears to be posted upstream, so use:

FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support

Reproduce locally:

# Check the commit prefix policy
bash kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 8c49474603c0b1c278b8fe00ac4e735b92d78ce9 \
  --head d088a35b9ce70817524a620fdadaea8fd1ebbd1b

Verdict

3 blockers must be fixed before merge:

  1. Checkpatch whitespace errors - Replace spaces with tabs in &pm8150_l11 block and remove extra blank lines
  2. Missing DT binding schema - Add Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml or verify it exists upstream
  3. Invalid commit prefix - Change "PENDING:" to "FROMLIST:" (or appropriate prefix)

The checkpatch issues are trivial formatting fixes. The dtb-check failure indicates a missing binding document that should be added/merged before the DTS changes. The compliance check requires updating the commit subject prefix to follow Qualcomm kernel conventions.

Device tree changes to support lt9611uxd hdmi-dsi driver.

Upstream-Status: Inappropriate [debug specific]
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>
@mohitdsor mohitdsor force-pushed the fix/my-second-change branch from d088a35 to bf4bf52 Compare June 27, 2026 21:55
@qlijarvis

Copy link
Copy Markdown

PR #763 — validate-patch

PR: #763

Verdict Issues Detailed Report
6 Full report

Final Summary

  1. Lore link present: No — FROMLIST prefix used but no Link: tag provided in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Cannot determine — no lore link provided; searches on lore.kernel.org found no matching patch from this author
  4. PR present in qcom-next: Not checked — validation blocked by missing upstream reference

Required Actions:

  • If posted upstream: Add Link: https://lore.kernel.org/r/<message-id> tag before Signed-off-by
  • If not posted upstream: Change FROMLIST: to QCLINUX: and remove Upstream-Status tag
  • Expand commit message body with technical rationale
  • Fix whitespace issues (trailing blank lines, inconsistent spacing)
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #763 - arm64: dts: qcom: Shikra LT9611UXD support
Upstream commit: N/A (no lore link provided)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No lore link provided; cannot verify upstream match
Body preserves rationale ⚠️ Minimal description; no technical rationale for changes
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Author: Mohit Dsor mohit.dsor@oss.qualcomm.com
Backport note (if applicable) FROMLIST prefix requires Link: tag to lore posting

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Cannot verify against upstream without lore link

Issues

Critical:

  1. Missing lore link: Patch uses FROMLIST: prefix but provides no Link: tag pointing to the upstream posting on lore.kernel.org
  2. Contradictory tags: FROMLIST: implies the patch is posted upstream for review, but Upstream-Status: Inappropriate [debug specific] suggests it's not intended for upstream
  3. Incomplete commit message: Body contains only one line with no technical justification for the hardware enablement

Commit Message Requirements:

  • FROMLIST patches MUST include a Link: tag with the lore.kernel.org URL (e.g., Link: https://lore.kernel.org/r/<message-id>)
  • The commit body should explain what hardware is being enabled and why these specific DT nodes are needed
  • Either remove FROMLIST: and use QCLINUX: for vendor-only changes, OR provide the upstream lore link

Style Issues:

  • Extra blank lines at end of file (lines 807-808)
  • Inconsistent spacing before &pm8150_gpios block (double newline at line 538)
  • Mixed indentation style (spaces vs tabs) in &pm8150_l11 block (line 541)

Verdict

Reject — Patch cannot be validated without upstream lore link. The FROMLIST prefix requires a Link: tag to the mailing list posting. If this is vendor-specific debug code not intended for upstream, use QCLINUX: prefix instead and remove the Upstream-Status tag.

Final Summary

  1. Lore link present: No — FROMLIST prefix used but no Link: tag provided in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Cannot determine — no lore link provided; searches on lore.kernel.org found no matching patch from this author
  4. PR present in qcom-next: Not checked — validation blocked by missing upstream reference

Required Actions:

  • If posted upstream: Add Link: https://lore.kernel.org/r/<message-id> tag before Signed-off-by
  • If not posted upstream: Change FROMLIST: to QCLINUX: and remove Upstream-Status tag
  • Expand commit message body with technical rationale
  • Fix whitespace issues (trailing blank lines, inconsistent spacing)

@qlijarvis

Copy link
Copy Markdown

PR #763 — checker-log-analyzer

PR: #763
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28303023174

Checker Result Summary
Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Undocumented compatible string 'lontium,lt9611uxd'
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Missing 'Link:' tag in commit message
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #763 - FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28303023174

Checker Result Summary
checkpatch 4 errors, 4 warnings, 2 checks: whitespace/indentation issues
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Undocumented compatible string 'lontium,lt9611uxd'
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance Missing 'Link:' tag in commit message
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check N/A Not applicable for qcom-6.18.y branch

❌ checkpatch

Root cause: Whitespace and indentation errors in arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:541-544

Failure details:

ERROR: code indent should use tabs where possible
#140: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:541:
+        /* DSI VDDA - must be at NOM voltage for PHY PLL lock */$

ERROR: code indent should use tabs where possible
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;$

WARNING: please, no spaces at the start of a line
#141: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:542:
+        regulator-min-microvolt = <1232000>;$

ERROR: code indent should use tabs where possible
#142: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:543:
+        regulator-max-microvolt = <1232000>;$

ERROR: code indent should use tabs where possible
#143: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:544:
+        regulator-allow-set-load;$

CHECK: Please don't use multiple blank lines
#138: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:539:
+
+

CHECK: Please don't use multiple blank lines
#183: FILE: arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts:808:
+
+

WARNING: DT compatible string "lontium,lt9611uxd" appears un-documented

Fix:

  1. Replace spaces with tabs in lines 541-544 of the &pm8150_l11 block
  2. Remove extra blank lines at lines 539 and 808
  3. Document the compatible string (see dtb-check fix below)

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8c49474603c0b1c278b8fe00ac4e735b92d78ce9..HEAD

❌ dtb-check

Root cause: Compatible string lontium,lt9611uxd is not documented in device tree bindings

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: 
i2c@4a90000 (qcom,geni-i2c): 'lt,lt9611uxd@41' does not match any of the regexes: ...

arch/arm64/boot/dts/qcom/shikra-iqs-evk-imx577-camera.dtb: 
/soc@0/geniqup@4ac0000/i2c@4a90000/lt,lt9611uxd@41: failed to match any schema with compatible: ['lontium,lt9611uxd']

Fix:

  1. Add device tree binding documentation for lontium,lt9611uxd in Documentation/devicetree/bindings/display/bridge/lontium,lt9611uxd.yaml
  2. OR use the existing documented compatible string if one exists (check Documentation/devicetree/bindings/display/bridge/ for similar Lontium chips like lt9611 or lt9611uxc)
  3. If this is a variant of an existing chip, consider using the base compatible as a fallback

Reproduce locally:

make O=temp-out defconfig
make O=temp-out CHECK_DTBS=y qcom/shikra-iqs-evk.dtb

❌ check-patch-compliance

Root cause: Commit message missing required Link: tag for FROMLIST commits

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support
No 'Link' found in commit message

Fix:
Add a Link: tag to the commit message pointing to the upstream mailing list submission. The commit message should follow this format:

FROMLIST: arm64: dts: qcom: Shikra LT9611UXD support

Device tree changes to support lt9611uxd hdmi-dsi driver.

Link: https://lore.kernel.org/...
Upstream-Status: Inappropriate [debug specific]
Signed-off-by: Mohit Dsor <mohit.dsor@oss.qualcomm.com>

If the patch hasn't been submitted upstream yet, consider using DOWNSTREAM: prefix instead of FROMLIST:, or submit it upstream first.

Reproduce locally:

git log -1 --format=%B | grep -q "^Link:" || echo "Missing Link tag"

Verdict

3 blockers must be fixed before merge:

  1. checkpatch - Fix whitespace/indentation (use tabs, remove extra blank lines)
  2. dtb-check - Document the lontium,lt9611uxd compatible string or use existing documented compatible
  3. check-patch-compliance - Add Link: tag to commit message or change prefix from FROMLIST: to DOWNSTREAM:

The fixes are straightforward: clean up whitespace, add DT binding documentation, and update the commit message with proper tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants