Skip to content

FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region#1427

Open
Jianping (Jianping-Li) wants to merge 1 commit into
qualcomm-linux:tech/all/dt/hamoafrom
Jianping-Li:hamoa_dt
Open

FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region#1427
Jianping (Jianping-Li) wants to merge 1 commit into
qualcomm-linux:tech/all/dt/hamoafrom
Jianping-Li:hamoa_dt

Conversation

@Jianping-Li

@Jianping-Li Jianping (Jianping-Li) commented Jun 29, 2026

Copy link
Copy Markdown

Reference the reserved memory region for audio PD dynamic loading and remote heap requirements. Add the required VMID list for memory ownership transfers.

Link: https://lore.kernel.org/all/20260629-hamoa-remoteheap-v1-1-aa868b7a6e65@oss.qualcomm.com/

CRs-Fixed: 4592586

@qcomlnxci qcomlnxci requested review from a team, Komal Bajaj (Komal-Bajaj), knaveen-qc and Shiraz Hashim (shashim-quic) and removed request for a team June 29, 2026 07:39
@qlijarvis

Copy link
Copy Markdown

PR #1427 — validate-patch

PR: #1427

Verdict Issues Detailed Report
⚠️ 5 Full report

Final Summary

  1. Lore link present: Yes — Link tag points to https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network access restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list (v1 posted 2026-04-18) but not yet merged to mainline
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Note: This validation is limited by network restrictions. The patch structure, commit message format, authorship, and internal consistency are all correct. To complete validation, the upstream patch should be fetched from lore.kernel.org and compared line-by-line with pr.patch when network access is available.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1427 - FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region
Upstream commit: https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (cannot verify against upstream due to network restrictions)

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot fetch upstream; subject follows kernel DT conventions
Body preserves rationale Clear explanation of audio PD remote heap and VMID requirements
Fixes tag present/correct N/A Not a fix; no Fixes tag expected
Authorship preserved Author and Signed-off-by match: Jianping Li
Backport note (if applicable) N/A FROMLIST prefix indicates pending upstream, not backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/hamoa.dtsi Adds SCM include, memory-region, and qcom,vmids properties; changes align with commit message

Issues

None detected in commit message or diff structure. The patch is internally consistent:

  • Added #include <dt-bindings/firmware/qcom,scm.h> is used by QCOM_SCM_VMID_* constants
  • memory-region property references adsp_rpc_remote_heap_mem (assumed defined in reserved-memory node)
  • qcom,vmids property lists two VMIDs for memory ownership transfer as described
  • Subject line is 66 characters (within 75 char guideline)
  • Commit message body is concise and explains the purpose clearly

Verdict

Patch structure and commit message are correct. Cannot verify diff faithfulness to upstream due to network restrictions preventing lore.kernel.org access. Based on local analysis, the patch follows kernel DT conventions and is internally consistent.

Final Summary

  1. Lore link present: Yes — Link tag points to https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/
  2. Lore link matches PR commits: Cannot verify — network access restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list (v1 posted 2026-04-18) but not yet merged to mainline
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Note: This validation is limited by network restrictions. The patch structure, commit message format, authorship, and internal consistency are all correct. To complete validation, the upstream patch should be fetched from lore.kernel.org and compared line-by-line with pr.patch when network access is available.

@qlijarvis

Copy link
Copy Markdown

PR #1427 — checker-log-analyzer

PR: #1427
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28356288948

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check No new DTB validation errors
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Author mismatch detected
tag-check N/A Not applicable for this branch
qcom-next-check FROMLIST prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1427 - FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28356288948

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check No new DTB validation errors
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance Author mismatch detected
tag-check N/A Not applicable for this branch
qcom-next-check FROMLIST prefix present

❌ check-patch-compliance

Root cause: The commit author in the PR differs from the original upstream author on lore.kernel.org.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region
Author mismatch:
  Original author: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
  Commit author : Jianping Li <jianping.li@oss.qualcomm.com>

The checker compared the commit in PR #1427 against the upstream patch at:
https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/

The original author on lore is Ekansh Gupta, but the commit in this PR is authored by Jianping Li.

Fix: Preserve the original author when cherry-picking FROMLIST patches. Use one of these approaches:

  1. Amend the commit to restore the original author:

    git commit --amend --author="Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>"
    git push --force-with-lease
  2. Cherry-pick with proper authorship from the start:

    # When applying patches from lore, use b4 to preserve authorship:
    b4 am 20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com
    git am ./v1_*.mbx
  3. Add Co-developed-by if both authors contributed:

    From: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
    
    [commit message]
    
    Link: https://lore.kernel.org/all/20260418-hamoaaudio-v1-1-a92866f744a6@oss.qualcomm.com/
    Co-developed-by: Jianping Li <jianping.li@oss.qualcomm.com>
    Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
    Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
    

Reproduce locally:

cd /path/to/kernel
git clone https://github.com/qualcomm-linux/kernel-checkers.git
bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base <base-sha> \
  --head <pr-head-sha>

Verdict

1 blocker to fix: Author mismatch must be corrected before merge. The commit must preserve the original author (Ekansh Gupta) from the upstream lore patch, or include proper Co-developed-by attribution if both authors contributed to the change.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/dt/hamoa'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/dt/hamoa

@qcomlnxci qcomlnxci requested a review from a team July 1, 2026 02:46
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/dt/hamoa'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/dt/hamoa

Reference the reserved memory region for audio PD dynamic loading
and remote heap requirements. Add the required VMID list for memory
ownership transfers.

Link: https://lore.kernel.org/all/20260629-hamoa-remoteheap-v1-1-aa868b7a6e65@oss.qualcomm.com/
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1427

PR: #1427
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28497025727

# Error File:Line PR-introduced? Root Cause
N/A Merge conflicts (101 files) Multiple files No Pre-existing merge conflicts between PR branch tech/all/dt/hamoa and baseline qcom-next. PR only modifies arch/arm64/boot/dts/qcom/hamoa.dtsi, which has no conflicts.

Verdict

This is NOT a build failure caused by the PR. The build failed during the automerge phase due to 101 pre-existing merge conflicts between the PR's base branch and the integration baseline. The PR itself only modifies arch/arm64/boot/dts/qcom/hamoa.dtsi, which is not among the conflicting files. No compilation was attempted.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1427

PR: #1427
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28497025727

# Error File:Line PR-introduced? Root Cause
N/A Merge conflicts Multiple files No Pre-existing integration conflicts between PR branch tech/all/dt/hamoa and baseline qcom-next

Verdict

No compilation errors occurred. The build failed during the merge phase before compilation began due to pre-existing merge conflicts between the PR branch and the integration baseline.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1427 — validate-patch

PR: #1427

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — valid lore.kernel.org URL with proper message-ID format (20260629-hamoa-remoteheap-v1-1-aa868b7a6e65@oss.qualcomm.com)

  2. Lore link matches PR commits: Cannot verify — network access blocked; unable to fetch upstream patch for comparison

  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged to mainline; dated 2026-06-29 (2 days old)

  4. PR present in qcom-next: No — commit SHA 9475616 not found in qcom-next; expected for FROMLIST patches that are still under upstream review

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1427 - FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region
Upstream commit: https://lore.kernel.org/all/20260629-hamoa-remoteheap-v1-1-aa868b7a6e65@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (network access blocked; upstream comparison not possible)

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - network access blocked; subject format is correct
Body preserves rationale Clear description of audio PD dynamic loading and remote heap requirements
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Original author Ekansh Gupta preserved; co-maintainer SoB added
Backport note (if applicable) N/A FROMLIST prefix indicates patch is in review, not yet merged

Diff

File Status Notes
arch/arm64/boot/dts/qcom/hamoa.dtsi Adds SCM header include and fastrpc memory-region + vmids properties

Commit Message Analysis

Strengths:

  • ✅ Proper FROMLIST prefix indicating upstream review status
  • ✅ Valid lore.kernel.org Link tag present
  • ✅ Clear, concise subject line following DT conventions
  • ✅ Body explains the purpose (audio PD dynamic loading and remote heap)
  • ✅ Proper author attribution and sign-off chain
  • ✅ Date format is valid (Tue, 19 May 2026)

Technical Content:

  • ✅ Adds #include <dt-bindings/firmware/qcom,scm.h> for VMID constants
  • ✅ Adds memory-region property referencing adsp_rpc_remote_heap_mem
  • ✅ Adds qcom,vmids property with QCOM_SCM_VMID_LPASS and QCOM_SCM_VMID_ADSP_HEAP
  • ✅ Changes are minimal and focused on the fastrpc node
  • ✅ Proper indentation and formatting in the diff

Potential Concerns:

  • ⚠️ The patch references &adsp_rpc_remote_heap_mem but the reserved-memory node definition is not visible in this patch (likely defined elsewhere or in a prerequisite patch)
  • ⚠️ Cannot verify if upstream patch content matches exactly due to network restrictions

Verdict

Conditionally acceptable - Commit message structure, authorship, and diff format are correct. The patch follows kernel DT conventions and FROMLIST workflow. However, upstream content verification was blocked by network restrictions. Manual verification of the lore link is recommended before merge.

Final Summary

  1. Lore link present: Yes — valid lore.kernel.org URL with proper message-ID format (20260629-hamoa-remoteheap-v1-1-aa868b7a6e65@oss.qualcomm.com)

  2. Lore link matches PR commits: Cannot verify — network access blocked; unable to fetch upstream patch for comparison

  3. Upstream patch status: In review — FROMLIST prefix indicates patch posted to mailing list but not yet merged to mainline; dated 2026-06-29 (2 days old)

  4. PR present in qcom-next: No — commit SHA 9475616 not found in qcom-next; expected for FROMLIST patches that are still under upstream review

@qlijarvis

Copy link
Copy Markdown

PR #1427 — checker-log-analyzer

PR: #1427
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28497025882

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - merge setup failed
dt-binding-check ⏭️ Skipped - merge setup failed
dtb-check ⏭️ Skipped - merge setup failed
sparse-check ⏭️ Skipped - merge setup failed
check-uapi-headers ⏭️ Skipped - merge setup failed
check-patch-compliance ⏭️ Skipped - merge setup failed
tag-check N/A Not executed
qcom-next-check N/A Not executed

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1427 - FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28497025882

Checker Result Summary
checkpatch ⏭️ Skipped - merge setup failed
dt-binding-check ⏭️ Skipped - merge setup failed
dtb-check ⏭️ Skipped - merge setup failed
sparse-check ⏭️ Skipped - merge setup failed
check-uapi-headers ⏭️ Skipped - merge setup failed
check-patch-compliance ⏭️ Skipped - merge setup failed
tag-check N/A Not executed
qcom-next-check N/A Not executed

❌ CI Infrastructure Failure (All Checkers)

Root cause: The topic branch tech/all/dt/hamoa has unrelated Git history to the qcom-next baseline, causing the automerge integration step to fail before any checkers could run.

Failure details:

2026-07-01T06:17:34.0860668Z Merging topic branches...
2026-07-01T06:17:34.1091936Z ------------------------------------------
2026-07-01T06:17:34.1092452Z  ** Merging topic branch: topic/tech/all/dt/hamoa
2026-07-01T06:17:52.8801869Z fatal: refusing to merge unrelated histories
2026-07-01T06:17:52.9907147Z Merge failed, manual merge

The CI workflow attempts to:

  1. Create an integration branch based on qcom-next (commit 19b282f41758)
  2. Merge the topic branch topic/tech/all/dt/hamoa into it
  3. Then merge PR FROMLIST: arm64: dts: qcom: hamoa: add audio PD remote heap region #1427 on top

Step 2 fails because tech/all/dt/hamoa was created with a different Git history root than qcom-next.

Fix:

The topic branch tech/all/dt/hamoa needs to be rebased onto qcom-next to share a common Git history. This is a repository structure issue, not a code issue.

Option 1 (Recommended): Rebase the topic branch onto qcom-next:

git fetch origin qcom-next
git checkout tech/all/dt/hamoa
git rebase origin/qcom-next
git push --force-with-lease origin tech/all/dt/hamoa

Option 2: If the topic branch was intentionally created as an orphan branch, the CI workflow needs to be updated to use --allow-unrelated-histories when merging topic branches, or the PR should target a different base branch that shares history with the topic branch.

Option 3: Change the PR base branch to qcom-next directly instead of tech/all/dt/hamoa, if the topic branch is not required.

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-next
git checkout -b integ
git fetch https://github.com/qualcomm-linux/kernel-topics.git tech/all/dt/hamoa:topic-branch
git merge topic-branch
# Will fail with: fatal: refusing to merge unrelated histories

Verdict

CI infrastructure blocker - The checkers could not run due to a Git history mismatch between the topic branch tech/all/dt/hamoa and the qcom-next baseline. The patch content itself appears valid (adds audio PD remote heap region to hamoa.dtsi with proper FROMLIST tag and lore link), but cannot be validated until the topic branch history issue is resolved. This requires maintainer action to fix the topic branch structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants