feat: remove dependence on mui for spinner #2179
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| .map((code, index) => { | ||
| return ( | ||
| <span | ||
| className="-translate-x-[2px] -translate-y-[4px] scale-75" |
There was a problem hiding this comment.
FWIW: this is just a little futzing with the positioning by nudging things around until they looked right (since we're shirking the icon with scale-75 we have to get its position juuuuuuuuust right.
| > | ||
| <SpinnerIcon | ||
| className={cn(code.color === 'black' && 'text-primary')} | ||
| style={code.color !== 'black' ? { color: code.color } : {}} |
There was a problem hiding this comment.
From my testing, it doesn't look like code.color was actually doing anything. It was always returning 'black' but I still left the logic the same (for now).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #2179 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 306 306
Lines 62381 62381
=======================================
Hits 55554 55554
Misses 6827 6827 ☔ View full report in Codecov by Sentry. |
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Replace all instances of
<CircularProgress>with our own custom spinner. This removes our dependence on the MUI package.The new
<SpinnerIcon>uses theprogress_activityfrom our icon set and adds a spinning animation on it.