Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persist active sheet in URL #2139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: persist active sheet in URL #2139

wants to merge 2 commits into from

Conversation

jimniels
Copy link
Collaborator

Per this conversation in Slack, this updates the app so the current active sheet is stored in the URL (and therefore part of the share process).

Functionality:

  • When the user changes to any sheet (other than the first one), the URL updates to include a sheet param indicating which sheet is currently active, e.g. ?sheet=Sheet%201
  • When the user changes to the first sheet, the sheet param is removed

To test:

  • Change the active sheet in the sheet bar (or command palette) and see the active sheet show up in the URL bar.
  • Share the link to a sheet and see that it contains the active sheet in the URL

This also resolves an older issue by introducing the functionality into the app.

@cla-bot cla-bot bot added the cla-signed label Dec 20, 2024
Copy link

qa-wolf bot commented Dec 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Dec 20, 2024 9:32pm

@jimniels jimniels changed the base branch from qa to main December 20, 2024 18:15
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2139 December 20, 2024 18:17 Inactive
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (a26883a) to head (47ba78b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2139   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files         260      260           
  Lines       57583    57583           
=======================================
  Hits        52297    52297           
  Misses       5286     5286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimniels jimniels changed the title feat: automatically add sheet name to URL feat: persist active sheet in URL Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store sheet state in URL
2 participants