Update to upstream #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8eff4d0 Remove private hex test macro (Tobin C. Harding) Pull request description: We have this macro in `hex-conservative` now, remove the version here. This patch does not change the public API and only touches test code. ACKs for top commit: apoelstra: ACK 8eff4d0 clarkmoody: ACK 8eff4d0 Tree-SHA512: 93a08fff778930071cd1a28c19202e4a94ca8881b2e873538de2e942b71c2cd6184ed6364c572538a8a699295a71761c6f836accaf251a15683138b71f148fab
Signed-off-by: Vincenzo Palazzo <[email protected]>
Clippy warns: redundant guard As suggested, remove the redundant guard.
error[E0308]: mismatched types
--> bitcoin/src/psbt/raw.rs:87:24
|
87 | return Err(encode::Error::OversizedVectorAllocation {
| ________________________^
88 | | requested: key_byte_size as usize,
89 | | max: MAX_VEC_SIZE,
90 | | });
| |_____________^ expected enum `psbt::error::Error`, found enum `consensus::encode::Error`
|
help: try wrapping the expression in `psbt::error::Error::ConsensusEncoding`
|
87 ~ return Err(psbt::error::Error::ConsensusEncoding(encode::Error::OversizedVectorAllocation {
88 | requested: key_byte_size as usize,
89 | max: MAX_VEC_SIZE,
90 ~ }));
|
----
Compiling bitcoin v0.30.0 (/home/vincent/github/work/rust-btc/rust-bitcoin/bitcoin)
Checking bitcoin-fuzz v0.0.1 (/home/vincent/github/work/rust-btc/rust-bitcoin/fuzz)
error: redundant clone
--> bitcoin/examples/taproot-psbt.rs:453:77
|
453 | witness_utxo: { Some(TxOut { value, script_pubkey: script_pubkey.clone() }) },
| ^^^^^^^^ help: remove this
|
= note: `-D clippy::redundant-clone` implied by `-D warnings`
note: this value is dropped without further use
--> bitcoin/examples/taproot-psbt.rs:453:64
|
453 | witness_utxo: { Some(TxOut { value, script_pubkey: script_pubkey.clone() }) },
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
error: could not compile `bitcoin` due to previous error
warning: build failed, waiting for other jobs to finish...
error: redundant clone
--> bitcoin/src/psbt/mod.rs:1095:13
|
1095 | .clone()
| ^^^^^^^^ help: remove this
|
= note: `-D clippy::redundant-clone` implied by `-D warnings`
note: this value is dropped without further use
--> bitcoin/src/psbt/mod.rs:1094:17
|
1094 | assert!(psbt
| _________________^
1095 | | .clone()
| |____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
6b5d06f ci: fix the byteorder to 1.4.3 for edition 2018 (Vincenzo Palazzo) 98513ef clippy: more worning fixes (Vincenzo Palazzo) 05d3dc5 Remove redundant guard (Tobin C. Harding) 4537634 ci: bump rustc to 1.60 for fuzz test (Vincenzo Palazzo) Pull request description: Ci looks like broken, so this should fix it ACKs for top commit: apoelstra: ACK 6b5d06f Tree-SHA512: bfa0eaf8cbc02a671237d99221db8c21264ce9df91301818c95c41dcc5ad4935e91254b0b3fa8f36738a9d71b6541fb8784ac8280d67057960a3d20e385a9f17
To avoid YAML automatic parsing of inputs as floats, e.g. [`1.60` being parsed as `1.6`](rust-bitcoin#2109 (comment)), it is best to future-proof the `toolchain` input in CI fuzz testing as a string.
3e6021b ci: fuzz test YAML toolchain future-proof (Einherjar) Pull request description: To avoid YAML automatic parsing of inputs as floats, e.g. [`1.60` being parsed as `1.6`](rust-bitcoin#2109 (comment)), it is best to future-proof the `toolchain` input in CI fuzz testing as a string. ACKs for top commit: vincenzopalazzo: ACK rust-bitcoin@3e6021b apoelstra: ACK 3e6021b tcharding: ACK 3e6021b Tree-SHA512: 838afb401fcfbb00717d6d3efff013cda08dabe4962ee0e914c3cf438a5cc8e83fa336dbd920b299fe95f935c0c1d76cf15d3f6fc6f763ea15a1746e7254d94f
Update the `bech32` dependency to use the newly release beta version. The main fix here is silent, a bug fix in `bech32` that was being hit by our fuzzing suite.
33ee49f Update bech32 dependency (Tobin C. Harding) Pull request description: Update the `bech32` dependency to use the newly release beta version. The main fix here is silent, a bug fix in `bech32` that was being hit by our fuzzing suite. ACKs for top commit: vincenzopalazzo: ACK rust-bitcoin@33ee49f clarkmoody: ACK 33ee49f realeinherjar: tACK 33ee49f apoelstra: ACK 33ee49f Tree-SHA512: 1464d00ddc16bb4a3c72e2c6b667c8b115b6fc883cf5b0da03378b9a1ad07b49f5b43e1d8ece56e2a0c6d795d50ea3d809e9245aea69bde4b44d247041c7dcc5
In preparation for updating the secp dependency to v0.28.0, which includes a change of `KeyPair` to `Keypair`, change our identifier usage to indicate that "keypair" is a single word. Deprecate the old forms.
Upgrade the `secp256k1` dependency to the newly released `v0.28.0`. FTR this includes two simple changes: - Use `Message::from_digest_slice` instead of `Message::from_slice`. - Use `secp256k1::Keypair` instead of `secp256k1::KeyPair`.
old: `actions-rs/toolchain` new: `dtolnay/rust-toolchain` fix ci(fuzz): change runner to ubuntu-latest ci: update run syntax in fuzz job ci: update and run fuzz/generate-files.sh
We have a new API function available with recent version of `secp256k1` to create a `Message` directly from a sighash byte array. Use `Message::from_digest(sighash.to_byte_array())` to construct messages ready to sign.
The `Params::pow_limit` field is currently a `Work` type, this is incorrect. The proof of work limit is the highest _target_ not the lowest work (even though these have a relationship). Note that we use the highest _attainable_ target, this differs from Bitcoin Core and the reasoning is already documented in the code. Add new consts and document where they came from as well as how they differ to Core. Use the new consts in the various network specific `Params` types.
539f4ba apoelstra run of generate-files.sh (Andrew Poelstra) 20f3a05 ci: replace fuzz toolchain (Einherjar) Pull request description: 1. Changes the toolchain fom `actions-rs/toolchain` to `dtolnay/rust-toolchain`. Closes rust-bitcoin#2113. 1. Changes the CI runner from `ubuntu-20.04` to `ubuntu-latest`. Related rust-bitcoin#2114. 1. Updates the `fuzz/generate-files.sh` to match `.github/workflows/fuzz.yml`. Closes rust-bitcoin#2115. ACKs for top commit: realeinherjar: > ACK [539f4ba](rust-bitcoin@539f4ba) apoelstra: ACK 539f4ba vincenzopalazzo: ACK rust-bitcoin@539f4ba tcharding: ACK 539f4ba Tree-SHA512: 3f1c744022794f1d1dbb7c7dc10d6d5252431ce54ee2309c906183c3c12570ac5e7833bb352749ad9be336b404ae3dd42fcf414107fb7a5bc73043cf5158cb88
678eee8 Use Message::from_digest (Tobin C. Harding) 6f30ac9 Upgrade the secp dependency (Tobin C. Harding) 818a3c5 Use Keypair instead of KeyPair in identifiers (Tobin C. Harding) Pull request description: Upgrade the `secp256k1` dependency to the newly released `v0.28.0`. FTR this includes two simple changes: - Use `Message::from_digest_slice` instead of `Message::from_slice`. - Use `secp256k1::Keypair` instead of `secp256k1::KeyPair`. But to stay in line with the keypair change we deprecate and rename the tweaked alias. ACKs for top commit: vincenzopalazzo: ACK rust-bitcoin@678eee8 apoelstra: ACK 678eee8 sanket1729: ACK 678eee8. Tree-SHA512: 3a86eccc4a638e5e17c4e4a4a310c8812d6c9a0ea19be679234b2390ca586befe755984d1321c22f9adb6d5efd412f4638e99364ec18e82d74ca55ecf00f8587
38005f6 Use Target for pow_limit (Tobin C. Harding) Pull request description: The `Params::pow_limit` field is currently a `Work` type, this is incorrect. The proof of work limit is the highest _target_ not the lowest work (even though these have a relationship). Note that we use the highest _attainable_ target, this differs from Bitcoin Core and the reasoning is already documented in the code. Add new consts and document where they came from as well as how they differ to Core. Use the new consts in the various network specific `Params` types. Fix: rust-bitcoin#2106 ACKs for top commit: junderw: ACK 38005f6 apoelstra: ACK 38005f6 Tree-SHA512: 5e71f69cdd555fd95a52fc1479e27b5e11226772f6432758c1364107a068bd1271486da6db1ece694da0287ce10cfbc18d28d6e3dbb0b9d387ff968eea43ab18
In preparation for the first rc release; bump the version number.
6731e85 bitcoin: Bump version to 0.31.0-rc1 (Tobin C. Harding) Pull request description: Lets go! As discussed in rust-bitcoin#2099 we are going to do RC releases for this release. This PR is for the first one, as such it does not include changelog entries, we are going to try out using the new github action to create those. ACKs for top commit: apoelstra: ACK 6731e85 Kixunil: ACK 6731e85 Tree-SHA512: 8c97a6885f8b77e5be85dcaca79428bdb88167681bd6ff2b4fd020b9d695c0e847c37a57ac73d432f22b049e47fefa11c0b3e4ca486ea8af8b93df164542ef6c
The macro psbt_with_values is used by the psbt test module. Since there is no pre-processing required, there is no reason to use metaprogramming here, so this commit moves the logic from a macro to common function in the test module.
hex_psbt was added as a macro so that a panic would reveal the line number of the failing test by expanding the macro at the test location. However, a stack trace can be used to reveal the test that caused the failure using RUST_BACKTRACE=1. Furthermore, the track_caller macro is added to the helper methods which will reveal the line number of the calling function (the offending test). More detailed information for debugging has been added to hex_psbt() so that the offending string will be included in the panic message.
The current MSRV is greater than rustc 0.29.
…to include block hash b108ffa Implement manual fmt::Debug for BlockHeader to include block hash (Steven Roose) Pull request description: I think it makes sense for a block header to have the block hash shown in the debug print. ACKs for top commit: tcharding: ACK b108ffa vincenzopalazzo: ACK rust-bitcoin@b108ffa apoelstra: ACK b108ffa Tree-SHA512: 37b77f8b2d8da3903bc5ff329abd45dcb5f189ba2ac38fc309fa477b0eb569b01dd85c41f160e073bb56b4a599b7c4774fbfbd8da4b82ddb41540d60bfeafea3
Add the remaining changelog entries for the v0.31.0 release. Includes everything released in v0.31.0-rc1
If our custom dev scripts get a `just` command it makes them more discoverable for new contributors. Add a command to run the `update-lock-files.sh` script.
In preparation for doing the next RC release bump the version.
a92d49f Implement `CompressedPublicKey` (Martin Habovstiak) Pull request description: P2WPKH requires keys to be compressed which introduces error handling even in cases when it's statically known that a key is compressed. To avoid it, this change introduces `CompressedPublicKey` which is similar to `PublicKey` except it's statically known to be compressed. This also changes relevant code to use `CompressedPublicKey` instead of `PublicKey`. ACKs for top commit: tcharding: ACK a92d49f apoelstra: ACK a92d49f Tree-SHA512: ff5ff8f0cf81035f042dd8fdd52a0801f0488aea56f3cdd840663abaf7ac1d25a0339cd8d1b00f1f92878c5bd55881bc1740424683cde0c28539b546f171ed4b
Returning `Self` instead of the actual type makes refactoring easier, especially for error enums.
There are various challenges when making code `const`: making it conditional, awkward copying of slices... This change adds tools that help dealing with these challenges.
The `arrayvec::ArrayVec` type is not `Copy` which is not nice and we would like to have a `Copy` type in our crates. While the PR to add support to the `arrayvec` crate is not merged we implement our own simplified version. This one acts mostly as a dumb storage - it has just a few methods and traits. The new ones can be added as needed later.
Add a new type `NetworkKind` the describes the kind of network we are on, ether mainnet or one of the test nets (testnet, regtest, signet). Do not use the type yet.
We only use the network to serialize and deserialize from WIF. For this we only really need network kind since WIF only differentiates between mainnet and non-mainnet.
BIP-32 only differentiates between mainnet and some testnet when encoding and decoding xpubs and xprivs. As such we can use the new `NetworkKind` type instead of `Network` throughout the `bip32` module.
These sections have been removed but still have links in the index.
We can have a standard set of derives to make it easier for new devs to work out what to use and also to help us move towards a uniform set in preparation for crate stabilization. Mention the new `ordered` crate.
7c3b198 Add a simple `Copy`-able `ArrayVec` (Martin Habovstiak) f17c040 Add tools that help with making code `const` (Martin Habovstiak) Pull request description: While we decided to use `arrayvec::ArrayVec`, unfortunately it currently isn't `Copy` even if `T` is because of unfortunate interactions with the `Drop` trait. So this adds a super-simple custom version that is `Copy` and may be extended if we need to or replaced with `arrayvec` if they start supporting `Copy`. ACKs for top commit: tcharding: ACK 7c3b198 apoelstra: ACK 7c3b198 Tree-SHA512: 545cb99c910f9455185a78a77a1110374e45a11e374c698316a222e599737b82ec2ac5c8ef1a8fe7037f20d938b1a4061685b6c673061b706dc9df9478de2b48
472da02 policy: Add section on returning Self (Tobin C. Harding) Pull request description: Returning `Self` instead of the actual type makes refactoring easier, especially for error enums. ACKs for top commit: Kixunil: ACK 472da02 apoelstra: ACK 472da02 Tree-SHA512: 22c74ed02b06907a3e2d79e82620e90e5cad2bd64322fc87ce01640c1ca51907c43329211952c62776834bbdce936f312f82ab166e85a8559614cfa25c0db708
This commit adds the arrayvec dependency to the sortKey.
4354f37 Use NetworkKind in bip32 module (Tobin C. Harding) 35bbfcd Use NetworkKind in PrivateKey (Tobin C. Harding) d22f382 Use NetworkKind in address module (Tobin C. Harding) 6d5ef23 Add NetworkKind (Tobin C. Harding) Pull request description: Add a new type `NetworkKind` the describes the kind of network we are on, ether mainnet or one of the test nets (testnet, regtest, signet). Use it in `Address`, `PrivateKey`, and `bip32`. ACKs for top commit: Kixunil: ACK 4354f37 apoelstra: ACK 4354f37 Tree-SHA512: d015283b55b2dc68c0a5cc5f17332fce648d3e4fb4e63e0b61943b7edfe4112e8ace760cb743cd3fd5ad0c34636e51a6a12382b34b6e62dfd7dab894d2ceefc0
8783d52 fix : adds the arrayvec dependency (harshit933) Pull request description: This commit adds the arrayvec dependency to the sortKey. Potential fix rust-bitcoin#2276 ACKs for top commit: Kixunil: ACK 8783d52 apoelstra: ACK 8783d52 Tree-SHA512: 35f28ade02dd526ce5dfa2f42578b36cd5af29a5a9f409da70a775bc12046674737e9bce9fabcc87f1b4669080ad10465c75601342f280c11eab11f791f44c36
cb42c74 policy: Add section on standard set of derives (Tobin C. Harding) ec1a5a2 CONTRIBUTING: Remove stale links (Tobin C. Harding) Pull request description: We can have a standard set of derives to make it easier for new devs to work out what to use and also to help us move towards a uniform set in preparation for crate stabilization. This is not me imposing my view but rather a place for the discussion to happen, could have been a discussions topic also? Using "open" instead of "draft" to aid visibility. Probably requires more than the usual amount of acks. ACKs for top commit: apoelstra: ACK cb42c74 Kixunil: ACK cb42c74 Tree-SHA512: b4c4094ea3652e92a5bea90e16f13971202710166524cc15abef5e8318ba5f59df084f5246331870fc641456b49d4e35d266c937375bdc5035f03699a7d4c1b9
5af7727 2023-12-17 automated rustfmt nightly (Fmt Bot) Pull request description: Automated nightly `rustfmt` changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action ACKs for top commit: Kixunil: ACK 5af7727 apoelstra: ACK 5af7727 Tree-SHA512: f3a4c7e80cc7d30eb10572bf44f3a0cd44748dd4f24a0d9f0fcf7de4f5c351c1dd17cbd80253b074f9fdac7e1bcf4bab7b0fbe61067e9a9dafc4fe5c25f1ab52
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
7e2321d Bump actions/download-artifact from 3 to 4 (dependabot[bot]) Pull request description: Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/download-artifact/releases">actions/download-artifact's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p> <p>For more information, see the <a href="https://github.com/actions/toolkit/tree/main/packages/artifact"><code>@actions/artifact</code></a> documentation.</p> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/bflad"><code>@bflad</code></a> made their first contribution in <a href="https://redirect.github.com/actions/download-artifact/pull/194">actions/download-artifact#194</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/download-artifact/compare/v3...v4.0.0">https://github.com/actions/download-artifact/compare/v3...v4.0.0</a></p> <h2>v3.0.2</h2> <ul> <li>Bump <code>@actions/artifact</code> to v1.1.1 - <a href="https://redirect.github.com/actions/download-artifact/pull/195">actions/download-artifact#195</a></li> <li>Fixed a bug in Node16 where if an HTTP download finished too quickly (<1ms, e.g. when it's mocked) we attempt to delete a temp file that has not been created yet <a href="hhttps://redirect.github.com/actions/toolkit/pull/1278">actions/toolkit#1278</a></li> </ul> <h2>v3.0.1</h2> <ul> <li><a href="https://redirect.github.com/actions/download-artifact/pull/178">Bump <code>@actions/core</code> to 1.10.0</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/download-artifact/commit/7a1cd3216ca9260cd8022db641d960b1db4d1be4"><code>7a1cd32</code></a> Merge pull request <a href="https://redirect.github.com/actions/download-artifact/issues/246">#246</a> from actions/v4-beta</li> <li><a href="https://github.com/actions/download-artifact/commit/8f32874a49903ea488c5e7d476a9173e8706f409"><code>8f32874</code></a> licensed cache</li> <li><a href="https://github.com/actions/download-artifact/commit/b5ff8444b1c4fcec8131f3cb1ddade813ddfacb1"><code>b5ff844</code></a> Merge pull request <a href="https://redirect.github.com/actions/download-artifact/issues/245">#245</a> from actions/robherley/v4-documentation</li> <li><a href="https://github.com/actions/download-artifact/commit/f07a0f73f51b3f1d41667c782c821b9667da9d19"><code>f07a0f7</code></a> Update README.md</li> <li><a href="https://github.com/actions/download-artifact/commit/7226129829bb686fdff47bd63bbd0d1373993a84"><code>7226129</code></a> update test workflow to use different artifact names for matrix</li> <li><a href="https://github.com/actions/download-artifact/commit/ada9446619b84dd8a557aaaec3b79b58c4986cdf"><code>ada9446</code></a> update docs and bump <code>@actions/artifact</code></li> <li><a href="https://github.com/actions/download-artifact/commit/7eafc8b729ba790ce8f2cee54be8ad6257af4c7c"><code>7eafc8b</code></a> Merge pull request <a href="https://redirect.github.com/actions/download-artifact/issues/244">#244</a> from actions/robherley/bump-toolkit</li> <li><a href="https://github.com/actions/download-artifact/commit/3132d12662b5915f20cdbf449465896962101abf"><code>3132d12</code></a> consume latest toolkit</li> <li><a href="https://github.com/actions/download-artifact/commit/5be1d3867182a382bc59f2775e002595f487aa88"><code>5be1d38</code></a> Merge pull request <a href="https://redirect.github.com/actions/download-artifact/issues/243">#243</a> from actions/robherley/v4-beta-updates</li> <li><a href="https://github.com/actions/download-artifact/commit/465b526e63559575a64716cdbb755bc78dfb263b"><code>465b526</code></a> consume latest <code>@actions/toolkit</code></li> <li>Additional commits viewable in <a href="https://github.com/actions/download-artifact/compare/v3...v4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> ACKs for top commit: apoelstra: ACK 7e2321d and will use CI-only one-ack carveout Tree-SHA512: 8eb6c18ce8c2b99721f134a26e7407c8ebc1d6af4999a013ed395b52795852ddee1c24b1f8aaf60487f13a0c1288d6b496c34d0dbfe20f806fd6fe5643e02250
This lint triggers on `fn input_len(&self) -> usize { match *self {} }`
where Self is an infallible type, claiming that the dereference of self
is UB. Maybe it would be, if this were possible. But it's not, and this
is literally the only point of using infallible types, so this lint is
always wrong.
Enabled in rustc 1.76 as warn by default.
Passing a complex expression to `match` is hard to read. Assign it to a variable first.
504f77a ci: revert rust-bitcoin#2301 "update download-artifact to v4" (Andrew Poelstra) 5fd731f Don't match on complex expression (Martin Habovstiak) 6cdbb04 clippy: whitelist uninhabited_references lint (Andrew Poelstra) Pull request description: Clippy has introduced a couple new lints that are causing our CI to fail. `allow` them. ACKs for top commit: tcharding: ACK 504f77a Kixunil: ACK 504f77a Tree-SHA512: 4b2312dcd1645792fa7c08ca02e8ec9f6a13fc5c275559e78293bb55be93997e21f952cf1ac66c1291c4699b6c2976289222201d7e9bbf68349030d83804f8f7
alejoacosta74
merged commit 91b7a9e
into
qtumproject:upstream_upgrade
2 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
rust-qtumto the latest version ofrust-bitcoin.