-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake for QtService #16
base: master
Are you sure you want to change the base?
Conversation
What about others? |
@KangLin if you wanna merge it to upstream, go to https://codereview.qt-project.org with your pr |
@Jihadist I want to merge it to the repository master. who can merge it? |
@KangLin pls look at https://www.qt.io/community/contribute-to-qt and then it's for you https://codereview.qt-project.org/q/project:qt-solutions/qt-solutions. Github repo is read-only, they merge only with codereview.qt-project.org |
I has add ssh key in https://codereview.qt-project.org/admin/repos/qt-solutions/qt-solutions but I don't push it. How do I do this? @Jihadist |
@KangLin you don't have permissons to push directly to master. You can push to your own branch. |
@Jihadist Yes! then where to watch my pacth? EWS url? |
@KangLin if you push it you will see it here https://codereview.qt-project.org/dashboard/self but looks like it wasnt pushed |
@Jihadist I am not see it. Is this right? |
@KangLin You are on the right track 👍 |
@Jihadist thank you! It is OK! Do you can review it? |
f60d731
to
9fd2c34
Compare
Change-Id: Icb8ce9458340d2dcc2f65bafa07ca282420751e4
Change-Id: I1a2aa1cb83e7cbff96ba1d4f3bd2cc7d8c0756cd
No description provided.