By default, border widths are rounded to integer values (in
QSGBasicInternalRectangleNode::updateGeometry()), so one avoids
artifacts where the rendered width can fluctuate with one pixel if the
Rectangle coordinates are fractional. However, that rounding was done
before the device pixel ratio scaling, so if the dpr was fractional,
one would get a fractional rendered border width, and hence
fluctuations.

Fix by taking the dpr into account. The rounding is done in the Item,
where the dpr is known, instead of the SG Node.

Fixes: QTBUG-108831
Change-Id: I9a1d8180c72dd5e1b1eaa9f1c420eb9944f1e5a5
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 73a3b69)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

When scaling with fractional values, aliasing can occur. Use the same
approach as BorderImage and respect the smooth property of
NinePatchImage. This property comes from QQuickImageBase, which sets it
to true by default. We change QQuickNinePatchImage's default value for
it to false, but this can be overridden by setting
QT_QUICK_CONTROLS_IMAGINE_SMOOTH to 1.

As NinePatchImage is not public API, and users would have to set the
smooth property on every image (where some items contain multiple
NinePatchImages), it's better to have one place to set this for all
controls.

[ChangeLog][Controls] The Imagine style now supports smooth scaling for
9-patch images when the QT_QUICK_CONTROLS_IMAGINE_SMOOTH environment
variable is set to 1.

Fixes: QTBUG-107989
Change-Id: I250a041f87c0270d67af191168f7bcfbf6237925
Reviewed-by: Richard Moe Gustavsen <[email protected]>
(cherry picked from commit 649151b)
Reviewed-by: Paul Wicking <[email protected]>

…in C++23)

... by rolling our own.

Qt 5.15 uses a pointer (additional indirection), not aligned_storage,
so isn't affected.

References:
- cplusplus/papers#197
- https://wg21.link/p1413

Manual conflict resolutions:
- adapted to different member names and private/public access in the
  6.2 class vis-a-vis the 6.4+ version.

Task-number: QTBUG-99122
Change-Id: Ia116dc11336901a19fc227fb68ac266c1bfbbcb1
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 6e9a9ed)
Reviewed-by: Qt CI Bot <[email protected]>

Change-Id: Ia8761ba9c2894e1eb534c479d55e2dfd10ecc2b1
Reviewed-by: Tarja Sundqvist <[email protected]>

Change-Id: I0231f2f00db9a6f6593a9e33e7eb35501c648b0b
Reviewed-by: Qt Submodule Update Bot <[email protected]>

Fixes: QTBUG-107492
Change-Id: I3f5ad0421bbd0822c76c5e32e42616461cde31c3
Reviewed-by: Leena Miettinen <[email protected]>
(cherry picked from commit 39e584f)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

...for source files that are outside of the source directory.

Having QML files that are generated in the build directory led
to *_qmlcache.cpp files with very long file names, hitting file system
limitations on Windows.

Apply the same fix that was done for generated qmlcache.qrc files in
commit 5d7710a.

Task-number: QTBUG-108150
Change-Id: Icef9dbf40fc7ade54b584bcdc8799c4cc95ac76d
Reviewed-by: Alexandru Croitor <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit e4feab1)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: Icb82ba585486d19afbb324e02ecf04658ba9c0fe
Reviewed-by: Qt Submodule Update Bot <[email protected]>

tst_qquickimageparticle::test_tabled is crashing randomly
whit Ubuntu 22.04

Task-number: QTBUG-107707
Change-Id: I43d00e0d66c867355d0dd52b001ee0c347bc0ce2
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>
(cherry picked from commit 29e3458)

It's the [set]sceneGraphBackend() functions that are from 5.8, the new
functions in Qt 6 are since 6.0.

Change-Id: If36f42615d53bd964f05ba42846b9322d8f1a0e4
Reviewed-by: Christian Strømme <[email protected]>
(cherry picked from commit 848f40f)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

It was possible to call c++-methods (either invokable or as slot) with
wrong arguments, which caused a crash.
The reason was that CallMethod(...) converted something to a QObject
without checking if it was an actual QObject. The wrongly typed argument
would end up reinterpret_cast'ed into another type for the call, which
leads to segmentation fault when accessing the argument in the function.

Added a test where an int tried to be reinterpret-cast'ed into a QFont.

Fixes: QTBUG-108994
Change-Id: I8c45c9124411ad3fd100faed0b03390843f7d034
Reviewed-by: Ulf Hermann <[email protected]>
(cherry picked from commit cda417c)

… attribute more prominent

Task-number: PYSIDE-1345
Change-Id: I765e32d367c36add97a08c03df5e0ac30e92e56e
Reviewed-by: Laszlo Agocs <[email protected]>
(cherry picked from commit c6e294f)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

A parent that filters mouse/touch events for a child might make the
child the exclusive grabber of the touch point when filtering, and the
child might have the keepTouchGrab property set. In that case, don't
override the exclusive grabber with the filtering parent.

Task-number: QTBUG-105312
Change-Id: Ic04513987d5ecb2cd0b12939b7d66091e85b35ee
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit f15f1d6)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

This broke in 80166d5,
so to ensure that doesn't happen again, add a test that is expected
to fail until the issue is fixed.

Task-number: QTBUG-105312
Change-Id: I70462304b5bf74c58420632a7e512be8d7cbb817
Reviewed-by: Volker Hilsheimer <[email protected]>
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit b31d4dc)

Amend 80166d5, which broke touch event
handling in SplitView. Implement handling of TouchBegin/Update/End
events equivalently to the mouse event handling.

As a drive-by, rename the logging category from 'mouse' to 'pointer',
and refactor the if/else sequence to a switch statement, reducing
duplication of code that's common for all event types.

Remove expectFail from the test that now passes.

Fixes: QTBUG-105312
Change-Id: I156f55fa40b2afaaa115e59940d26187121fc16a
Reviewed-by: Mitch Curtis <[email protected]>
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 6de2397)
Reviewed-by: Volker Hilsheimer <[email protected]>

The attached ListView.isCurrentItem property is updated when
QQuickItemViewPrivate::updateCurrent() method is called.
During the initialization it could be potentially called twice:
* from the QQuickItemView::setCurrentIndex() method, but that does
  not happen, because the isComponentCompleted() condition is not
  fulfilled at that time.
* from QQuickItemView::componentComplete() method, but that does
  not happen, because the d->isValid() condition is not fulfilled.
  The latter means that the model is not yet initialized.

This patch attempts to fix it by adding the updateCurrent() call
into layout() method. This method is called each time the
component needs to be redrawn, so it creates the proper
currentItem during the first call. Most of the subsequent calls
will do nothing, because the currentItem will be non-null, and
the currentIndex will not change.

The unit-test is taken from the reverted commit
d9f9d77.

Another unit-test is meant to check that there is no regression
like in QTBUG-98315.

Done-with: Joni Poikelin <[email protected]>
Fixes: QTBUG-86744
Change-Id: Iab86a9c0e22660126f152727e8bd393ac17f5d15
Reviewed-by: Mitch Curtis <[email protected]>
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 9124fce)
Reviewed-by: Ivan Solovev <[email protected]>

If the Drawer does not cover the whole window, it's possible to tap
outside the dimmer overlay. In that case, next time you tap on the
dimmer, you hit this early return in handleRelease in which
pressPoint.isNull(), so it was not setting touchId back to -1 and doing
the other cleanup/reset tasks.  This is a touch release, and touchId
should always be eventually reset after a touch release, regardless of
the code path.

Now QQuickDrawerPrivate::handleRelease() has a QScopeGuard to ensure
that cleanup is done regardless of early returns. That's still not
enough; but when we receive TouchEnd in QPopupPriv::handleTouchEvent(),
it means that _all_ touchpoints are released. So as a fallback for
multi-touch cases, we now ensure that all releases are handled and
stored state is reset, regardless of whether an individual point ID
matches the stored touchId.

Fixes: QTBUG-103811
Change-Id: Ia637bae00d8edb7f7f4c8fb4337b4c3d72fe4e60
Reviewed-by: Doris Verria <[email protected]>
(cherry picked from commit 730cdc5)
Reviewed-by: Mitch Curtis <[email protected]>

A previous patch 5647527 causes
a regression. The purpose of the patch, that caused this regression,
was to update the pressPos variables, in cases where the contentItem's
geometry was modified externally, while a user were dragging the
contentItem around.

The mistake that was made, was how width and height changes were
handled. We had previously added logic in setContentWidth() and
setContentHeight() that would call fixup() (with immediate fixupMode)
to ensure that the contentItem would immediately be repositioned
inside the flickable's viewport, if the contentItem was being dragged.

It turns out that setContentWidth() and setContentHeight() are being
called from QQuickItemViewPrivate::updateViewport(), which happens
quite often, while dragging. This would make fixup() and dragging
constantly interfere with each other, since they'd not always agree on
a specific position for the contentItem.

This patch reverts the changes made to setContentWidth() and
setContentHeight(), since it turns out that those changes weren't
necessary after all. QQuickFlickablePrivate::itemGeometryChanged() only
calls viewportMoved() on x and y changes anyways.

Done-with: Jan Arve Sæther <[email protected]>
Done-with: Santhosh Kumar Selvaraj <[email protected]>
Fixes: QTBUG-109140
Change-Id: I0bddf8685d3afc1ae04b2c092212d3c1bd742c3b
Reviewed-by: Paul Wicking <[email protected]>
(cherry picked from commit b307bf3)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I862a5809107914aa5b3dc30fe8bebdcbc16903b8
Reviewed-by: Qt Submodule Update Bot <[email protected]>

When we look up glyphs with subpixel positions in the glyph cache,
we use the calculated subpixel position (from a set of predefined
subpixel positions) as key. In some very rare cases, we could end
up with different subpixel positions when looking up an on-screen
position than when we entered it into the cache, due to numerical
differences when doing the calculation.

The reason for this was that when entering the glyph into the
cache, we used the 16.6 fixed point representation, whereas when
looking up, we used the unmodified float. In some cases, the
converted fixed point approximation might snap to a different
predefined subpixel position than the floating point equivalent.

To avoid this, we reuse the converted fixed point positions when
looking up the glyphs in the cache.

[ChangeLog][Text] Fixed an issue where text using NativeRendering
would sometimes be missing glyphs.

Fixes: QTBUG-108713
Change-Id: Iecc264eb3d27e875c24257eaefcfb18a1a5fb5be
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Lars Knoll <[email protected]>
(cherry picked from commit 4bad329)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Fixed a bug where QQuickPopupPositioner::reposition() was confusing
coordinates obtained by mapToSource() and mapToItem() during mirroring
of the popup. This leads to popups at the wrong places, e.g. when a
rotated combobox has not enough space to unroll its popup.

Translate the coordinates using mapToItem instead of mapToSource after
computing the alternative position of the popup (e.g. when it can not
be unrolled correctly).

Add a test to check if the combobox popup appears at the right places.
Skip native styles as they might be pushing the popup around, same
for Android as they might have too small screens (which involves
more positioning logic then just the mirroring).

Fixes: QTBUG-105148
Change-Id: I0033509a8824e3a71698f91ef832b94527d8e2c8
Reviewed-by: Oliver Eftevaag <[email protected]>
(cherry picked from commit 5c1d96b)

If we have a deep alias we need to bind to the inner object rather than
the outer one.

Fixes: QTBUG-109417
Change-Id: Iefe8641026cfbbf9199b2bb8d9fa2f5fba591f17
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit e9b7eaa)
Reviewed-by: Sami Shalayel <[email protected]>

Change-Id: Ia6afd11314a879e264198c73685dcd8886ca296e
Reviewed-by: Qt Submodule Update Bot <[email protected]>

Change-Id: I3130254c32e47d2ca055c641cd0cef6f8705505d
Reviewed-by: Qt Submodule Update Bot <[email protected]>

A big advantage of PinchHandler over PinchArea is the ability to zoom
into a particular location in the target Item, so let's not fail to
show that off.

Change-Id: I0f22abff99bdc60bac27e72fd5f66be4796794df
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit e39b457)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: Iab9599134113833cd9b63a7ae9d85e1f78577668
Reviewed-by: Qt Submodule Update Bot <[email protected]>

The C toupper/tolower functions are locale-dependent. Given the right
locale (Türkiye, e.g.), toupper(i) is either

- İ (LATIN CAPITAL LETTER I WITH DOT ABOVE; if representable) or
- i (unchanged; if it isn't)

Both results are wrong for the present use-case. Use the new
QtMiscUtils::toAsciiUpper() function instead.

Amends d481f2f.

Task-number: QTBUG-109235
Change-Id: Ib66593fc7eff3edc0cc16291ca3eae8bdf0dd8ed
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 179200d)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I469c4f813f006ca47f9660a0c9ccfa30bbe89dc6
Reviewed-by: Laszlo Agocs <[email protected]>
(cherry picked from commit f92a2a6)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Task-number: QTBUG-101736
Change-Id: Iecbe6b4da75851cb94c4c2bae41bb0cb50f0ed30
Reviewed-by: Volker Hilsheimer <[email protected]>
(cherry picked from commit 26cd43f)

A QQuickWidget contains a Quick UI, which can be expected to handle
touch events, and it handles touch events by forwarding them to the
QQuickWindow. So set the AcceptTouchEvents attribute and let the
Qt Quick delivery machinery deal with the touch-mouse synthesis
within the scene.

Also, Qt Quick's event delivery might return event points as ignored
after setting the exclusive grabber. Qt Widgets touch event delivery
logic doesn't care about exclusive grabbers, and relies on the event
points being accepted to make the widget that received the TouchBegin
an implicit grabber. QQuickWidget needs to translate those states back,
so accept all points that come back with a grabber.

Add a test that verifies that a button in a popup gets all events,
and that those events are translated correctly - without the fix,
the "clicked" test fails, as the release is delivered, but with
coordinates outside of the button.

Also test that we can have two QQuickWidgets where each gets one
touch point.

Fixes: QTBUG-101736
Change-Id: I3a2bf05fd297ae4d72b6e236ecd8e5ddac37ce06
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Paul Wicking <[email protected]>
(cherry picked from commit dc8f44b)
Reviewed-by: Volker Hilsheimer <[email protected]>

If the binding was not actually set (because the bindable is readonly)
then it's dead after the pop_front. We cannot examine it anymore, and we
don't have to.

Fixes: QTBUG-109597
Change-Id: I3bf0ca501aa9ad45a64ad181b685ca6d9d325231
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 4dfcaa7)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Those node recreations happen when the RHI backend is recreated.
One such case is GLX_NV_robustness_video_memory_purge

In such cases QQuickTransformAnimatorJob::invalidate()
will be called, however the node will never be re-set

Change-Id: I3136c220f41781689f4a271caf0543a3b659447c
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
(cherry picked from commit 0359381)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

In header view, the header proxy model which acts as proxy for table
model, connects headerDataChanged() signal to a slot with both sender
and receiver as table model object. This connection happens each time
header view instantiates or model in the header view need to be reset.

In a case, where header view reinstantiated (released and loaded) and
table model not released, the newly instantiated header proxy model
creates a connection to the existing table model for headerDataChanged()
signal and this creates a connection leak.

This can be avoided by making header proxy model as receiver
similar to other slots within the proxy model.

Fixes: QTBUG-108610
Change-Id: I1b250f98310e16743f7fc2c4cc11cbfb3d9fff45
Reviewed-by: Richard Moe Gustavsen <[email protected]>
(cherry picked from commit 6b4939d)
Reviewed-by: Santhosh Kumar <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>

If the requested size is not set, the QQuickImageBasePrivate::sourcesize
is -1. Multiplying it with devicePixelRatio is useless because it will
be still an invalid size and it will be ignored. Nonetheless,
QQuickImageBase::pixmapChange() will still divide the size with
devicePixelRatio resulting smaller images.

The issue is reproducible with the tst_qquickimageprovider auto test if
ran with QT_SCALE_FACTOR=2 set.

Fixes: QTBUG-109854
Change-Id: I9fea39c34144e5eae7e421bccc8dc65388dd5b32
Reviewed-by: Eirik Aavitsland <[email protected]>
(cherry picked from commit 1609f86)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

latest QuickTestUtils needs Qt::Network (QTBUG-107472)
Disable to build it and another module depending on QuickTestUtils
unless network is available.

Change-Id: Ib522efa68d9ca4669afaf1fc8bbb18b079995ac1
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit b539b1f)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

On 32bit platforms you cannot losslessly convert quint32 to qsizetype.
However, in the places we are facing here, we are only interested in
signed 32bit numbers anyway.

Change-Id: I93a07c2847bd5bfae426dccbb6c0e33c5758442d
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 4e1fe07)
Reviewed-by: Sami Shalayel <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>

The documentation format for QML methods is peculiar, but this should
do for now.

Fixes: QTBUG-90480
Change-Id: I0fdbb7f4a704990de1356010c8b7d44764b7e41a
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 4b7566a)

Change-Id: I81a8de8042fdd200b8a7874d04abaef469cad8f0
Reviewed-by: Qt Submodule Update Bot <[email protected]>

The 'int line' variable is shadowed a few lines below by the
'QByteArray line' one, even in the initial commit, so it can never
have been used, except for the increment in the first line of the
loop's bodies.

Remove the variable, fix the warning.

Found by Clang 15:

  test262runner.cpp:380:9: warning: variable 'line' set but not used [-Wunused-but-set-variable]
    int line = 0;
        ^

Amends d9c4a52.

Change-Id: I2139aa4552d1ff2ddbb5737e2a1b26650d6519e7
Reviewed-by: Ulf Hermann <[email protected]>
(cherry picked from commit 9d04888)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

It's a header, and at least tst_styleimports.cpp doesn't use all of
the functions, so throws a -Wunused-function warning on Clang 15 for
runTests():

  qtest_quickcontrols_p.h:36:12: warning: unused function 'runTests' [-Wunused-function]
    static int runTests(QObject *testObject, int argc, char *argv[])
               ^

Fix by marking the functions as inline instead.

Amends e310dad.

Change-Id: Id6cee7bdc2fe93a5e034d7ed445dc5f2c5d35360
Reviewed-by: Mitch Curtis <[email protected]>
(cherry picked from commit e34142e)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

The handling of the stroke color lacks the extra checks that are
performed when setting the fill color. Switching from "transparent"
to another color involves setting not just the color-dirty flag but
also the geometry-dirty since alpha == 0 may skip operations such as
triangulating, meaning the work has to be performed later when once
again switching to an alpha > 0 color.

Change-Id: Ibd6d762cfcb07ca8b9c852553c979bcb4ee9fa21
Fixes: QTBUG-109882
Reviewed-by: Christian Strømme <[email protected]>
(cherry picked from commit 650e7d4)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

You should really not use it, but people should know about it.

We cannot deprecate it because QtQuick Controls needs it.

Fixes: QTBUG-95448
Change-Id: Idcc31d13a8eaa709944f2271389642b7fdbe84fe
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 05908e6)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I86ba0659fcd5a0c38b664738b9e0b3b28562dbf5
Reviewed-by: Volker Hilsheimer <[email protected]>
(cherry picked from commit d09a077)

With file selectors, a type can exist in the same version under
different paths. Detect this case, canonicalize the filename to the
selector free version, and rely on the engine to resolve a URL to the
correct file.

Fixes: QTBUG-107797
Change-Id: I0f74fd37936abfa08547fb439bfa5264e6ca4787
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>
(cherry picked from commit 9bfb27b)
Reviewed-by: Sami Shalayel <[email protected]>

The estimated width in the table view has been used to layout
and accordingly, edges of the table be loaded. This estimated
width will be passed to flickable to adjust its parameters and
width/position of scroll bar. This in turn change geometry of
table view with respect to view port.

In some scenarios, this estimated width during layout causes
table view to be misaligned. This can be avoided by calculating
and updating latest content width of the table view once after
loading the edges of table.

Fixes: QTBUG-108664
Change-Id: I47c3325bc9e51f75c87564a2ec1de4522e4a7e60
Reviewed-by: Richard Moe Gustavsen <[email protected]>
(cherry picked from commit 19b3500)
Reviewed-by: Qt CI Bot <[email protected]>

There is a section for this on Container's page, so let's link to it in
more places.

Task-number: QTBUG-109996
Change-Id: I8c96f0cb0998d65a2c2669b6358236a14e0352dc
Reviewed-by: Mitch Curtis <[email protected]>
(cherry picked from commit 70f1732)
Reviewed-by: Fabian Kosmale <[email protected]>

Change-Id: If1180dba6ac977225e932d8a18baf0b8fcda56eb
Reviewed-by: Qt Submodule Update Bot <[email protected]>

qmlformat currently discards ES classes, and only reformats the element
list inside that class. Implement a class declaration visitor which
reformats ES classes in qml file.

Fixes: QTBUG-110321
Change-Id: I9fa2561902dbcfde5e8fb041bc5dedcc56bb66cc
Reviewed-by: Ulf Hermann <[email protected]>
(cherry picked from commit d962fe4)
Reviewed-by: Fabian Kosmale <[email protected]>

Actually it just reverts 4db31cb.
When calculating a position for a decoration, we should just apply the
decoration's offset to the line's baseline (line.y + line.ascent).
The regression was introduced by 54b5287adf4f5b004fcf47840c7f2e1e561a90c1
in Qt 5.6, when we switched from prepending leading to the baseline
of text and started appending it instead.

Fixes: QTBUG-96700
Fixes: QTBUG-97594
Change-Id: I7f816b71859ffcb6b1c641f0c8b8e1d810bfc525
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
(cherry picked from commit 5d082dc)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

This is the simplest way to prevent the garbage collector from
destroying the object while at the same time allowing a manual
destruction.

Task-number: QTBUG-95895
Task-number: QTBUG-96167
Fixes: QTBUG-91390
Change-Id: Ic3f3146bc555991068ce3367971e050f745d235d
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 718f346)

Change-Id: Ieb101f4a6275eaf00d3f75533dfb075116a539e5
Reviewed-by: Qt Submodule Update Bot <[email protected]>

While you can, technically, have URIs that contain '$', or '幽', '霊',
'文', and '字', you really shouldn't.

Amends commit 9e4f6d9.

Fixes: QTBUG-106074
Change-Id: Ic0f13b6ea2bb704d2bd9f4fa5841aa69a88cd5a7
Reviewed-by: Sami Shalayel <[email protected]>
Reviewed-by: Semih Yavuz <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit a29f316)

With this patch QQuickImageParticle will now properly re-query
the m_rhi member the next time updatePaintNode() is called

Additionally a new (override)
QQuickImageParticle::invalidateSceneGraph()
will call reset() so that potential sub-nodes (e.g. SpriteParticle)
will also be re-created

Last but not least: QQuickSpriteEngine::startAssemblingImage()
was missing to reset it's sprites container
(without that the sprites would pile up and eventually
fail with "Too many animations" error)

Change-Id: I172fd23ddfac475542aabc6cc17d8fee74f728b2
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
(cherry picked from commit b899dff)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Adding requestPaint() at the end of invalidateSceneGraph()
will make sure that painting is trigger properly again,
including the (re-)creation of the painting context.

As that request of painting will also recreate the painting
context, it will also allow the creation of a new QSGNode

Without this patch a nullptr will be returned as QSGNode
until a "proper" dirty or update() happens due to property changes
or explicit update calls.

Change-Id: If1e79d135d3d1f5253cb41a3be1630cfed3865dd
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
(cherry picked from commit 185b0d5)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I440daea1d39d1877a95632181f1ac0ecbfbd7888
Reviewed-by: Qt Submodule Update Bot <[email protected]>

Change-Id: Ic92e09ee1c76d2c5598075abce0c83e46b179464
Reviewed-by: Qt Submodule Update Bot <[email protected]>

QQuickRotation::applyTo(QMatrix4x4 *matrix) uses
QMatrix4x4::projectedRotate() to apply rotation in pseudo-3D.
QQuickFlipablePrivate::updateSide() was previously applying
QQuickRotation to QTransform to decide which side should be showing;
but when using QTransform::map(QPointF) to get the position of the
transformed point, it is affected by the distance-to-plane value.
QMatrix4x4::projectedRotate() uses 1024 as distance from "camera" to
plane; so if the items on the plane are too large, some coordinates on
the plane may be behind the camera during rotation, which could cause
QQuickFlipable to mistakenly think that the current side has become
QQuickFlipable::Back.

Now we directly calculate the side of QQuickFlipable in 3D space rather
than performing projection, to avoid being affected by the camera
distance value. We use QMatrix4x4 instead of QTransform.

Fixes: QTBUG-75954
Change-Id: Ibb08f6f6de690f5b56c3130a1f7b09beb250c807
Reviewed-by: Fabian Kosmale <[email protected]>
Reviewed-by: Mikołaj Boc <[email protected]>
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 036b615)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

When a ShaderEffect did not have any shaders, we would
register a "fake" bindPoint for the 'source' property with
bindPoint 0. However, when actually linking the default
shader program, the actual bindPoint is 1 (also matches
what is in shadereffect.frag).

When the property corresponding to the source updated, we
would thus register an update for binding point 0. The
initial value for binding point 1, from when the shader
effect was loaded, would never be overwritten and when we
iterated over the variables later and tried to cast do a
qobject_cast on the (initial, now dangling) pointer stored
for binding point 1, it would crash.

Fixes: QTBUG-110111
Change-Id: I96c3e81908db8cce682b5447800fcb7a3fe5e0b9
Reviewed-by: Laszlo Agocs <[email protected]>
(cherry picked from commit f708448)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: Idae763007475b450f178084cc569801255067100
Reviewed-by: Qt Submodule Update Bot <[email protected]>

Otherwise we just re-load the old cache file next time. That's clearly
not intended.

Fixes: QTBUG-111078
Change-Id: Ia65b46880eca2b6e8c4792a09f20716125beada3
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 0a5eff0)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Developers can easily break QDS .ui.qml files if they edit them
as code. Link to the description of UI files in QDS Manual.

Fixes: QTBUG-110354
Change-Id: Id5dc0e9fd420e0e4807a39d4f8d7d121e5137636
Reviewed-by: Thomas Hartmann <[email protected]>
(cherry picked from commit 5fabb87)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I8a28949a711e45027ffc1b760977a636fc15dde0
Reviewed-by: Qt Submodule Update Bot <[email protected]>

So far, we only documented the qmake workflow. Adjust the docs to
mention how the same can be achieved in CMake.
As a drive-by, use a versionless import in the QML example code.

Fixes: QTBUG-107902
Change-Id: I08ac1262d0d93572077ec86be3b02ce1524bf52a
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>
(cherry picked from commit 3126207)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Otherwise we may retain dangling pointers referencing invalid property
caches. Some metaobjects are created on the heap. If the memory manager
decides to re-use the heap space for new metaobjects, we can retrieve
the invalid property caches.

Task-number: QTBUG-110933
Change-Id: Ic00bb852151bcf58ba6ae798a6bf2cea686a9e10
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 6937f2e)

Amends a1c9178

Task-number: QTBUG-76381
Change-Id: I7fdd15abbe15805815f5d2b2fc298501e1ab34d7
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Topi Reiniö <[email protected]>
(cherry picked from commit 6215a53)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

It looks less tedious. Amends 8503f88

Change-Id: I85690e6a8ceac4ebec1c00bcbbf6a81108096e6c
Reviewed-by: Oliver Eftevaag <[email protected]>
(cherry picked from commit 40e2811)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: Icad96978a8344cc70c5dca99922b936ad785eb3c
Reviewed-by: Qt Submodule Update Bot <[email protected]>

It should result in NaN, not in 0.

[ChangeLog][QtQml][Important Behavior Changes] Converting a JavaScript
value to a double or float now always assumes JavaScript type coercion
semantics. In particular, converting a value that is not actually a
number now results in NaN where it previously sometimes resulted in 0.

Fixes: QTBUG-111179
Change-Id: If24444ae9014c8972761c565a6920f06699e485c
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit b9834e0)

Change-Id: I44a454cdae60d88af4c662b79d9e3cd06e90bbab
Reviewed-by: Qt Submodule Update Bot <[email protected]>

This is mentioned in the documentation for the transitions property
and in "Playing Animations in Parallel or in Sequence", but is easy to
miss if you only read the detailed description. It's an important
detail that users should know, so add it.

Change-Id: I6f074506ddc8a7b02e6114741d9fadef48cdc8ab
Reviewed-by: Nicholas Bennett <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 0bb5a91)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

…2-opensource

Change-Id: Ie5a87ae61d8ed0429225353ad46e5232d60f4daa

Like acceptedButtons, HoverHandler.dragThreshold is irrelevant.

Task-number: QTBUG-95395
Change-Id: I059e99449cff946b2caa945022b1f4bd4d2f845b
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 17e8e21)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Mouse buttons are irrelevant to PinchHandler, of course.

Change-Id: Idfe65d3408ff3a33314979174a886f3e51f2eb7b
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 69fa61a)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

The interpreter does this and so should the enum lookup adapter for
generated C++ code.

Fixes: QTBUG-109816
Change-Id: I576480c3ca808743ddc0ceaf2f0bd8a1de776a41
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 8cbb30a)

Instead of (partially) repeating the defaults listed in "QML Import
Path", link to that section.

Moreover, warn that setImportPath doesn't preserve the default paths.

Task-number: QTBUG-109799
Change-Id: I6c2acb6efd1bd0984b3b540a75c7bced44127050
Reviewed-by: Ulf Hermann <[email protected]>
(cherry picked from commit 2d8b15c)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

It was used in the code snippet, but we didn't explain so far why it was
there.

Change-Id: I53005d897f4a3732b7707c7cc0e88f2842ca7433
Reviewed-by: Mitch Curtis <[email protected]>
Reviewed-by: Santhosh Kumar <[email protected]>
(cherry picked from commit a703701)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Fixes: QTBUG-111566
Change-Id: Idf3d5fd140f2b69215844ff25b24bfc2abfc14b1
Reviewed-by: Mitch Curtis <[email protected]>
(cherry picked from commit 925c6b0)

Fixes unintentional fall-through.

Change-Id: Iab82677c5f81d16fefb3db04e10601a98cb81c67
Reviewed-by: Andy Nichols <[email protected]>
(cherry picked from commit 2770316)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: Iae701dec938c5f126ebf90953af0733de775b385
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit ee3d11f)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

The loadImages() function has been waiting already since
6318560); but test_url() was not
waiting, which could result in CI flakiness. Anyway tryVerify is better
than waiting 200ms every time it's slow, and will give us a failure
message about isImageLoaded() if it fails.

Task-number: QTBUG-41043
Change-Id: I0bb552d3452d85342d2ffa3b6becded5b01177a8
Reviewed-by: Mitch Curtis <[email protected]>
(cherry picked from commit e37d2da)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I5a919703ec6a9a55b620f3a02c6f6a28a891e71a
Reviewed-by: Qt Submodule Update Bot <[email protected]>

QML Loader creates multiple object of same component during initial
loading, if sourceComponent is assigned within state configuration
and it evaluates to be true. This happens due to the effect of
evaluating stage change (here in this case, setting loader source
component) during component completion which internally creates
component object and makes loader status be ready, even before
Loader instantiates object.

This patch adds a guard to check loader status and avoids object
creation if status is already ready.

Fixes: QTBUG-111559
Change-Id: I6c3456cd3bc35a717c139fbd3670c305304f480a
Reviewed-by: Fabian Kosmale <[email protected]>
Reviewed-by: Shawn Rutledge <[email protected]>
(cherry picked from commit 492dc98)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Hopefully this reduces flakiness in CI, following the suggestion from
the error message:

Unable to use getContext() at this time, please wait for available: true

Task-number: QTBUG-41043
Change-Id: I3710163cb197170e590f8fd7d188fa62f32ea649
Reviewed-by: Mitch Curtis <[email protected]>
(cherry picked from commit 223f1d4)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

Change-Id: I31c18e50e4f5e15fff7cc94d83ad6a94423f56e8
Reviewed-by: Qt Submodule Update Bot <[email protected]>

We need a link target for the GrabTransition enum argument in the
PointerHandler::grabChanged QML signal doc, and a few other places.
Fix warnings about failing to link in a couple of places.

Fixes: QTBUG-102160
Task-number: QTBUG-104761
Change-Id: I92a544d363a6ff9e990c7d56c110bc5db1202bb3
Reviewed-by: Topi Reiniö <[email protected]>
(cherry picked from commit e283c05)
Reviewed-by: Shawn Rutledge <[email protected]>

People are constantly confused by GesturePolicy and its default value,
so we really need a "glanceable" reference in the docs to show the
differences between use cases.

Also clarify the pitfalls with the default DragThreshold value.

We switch from the \value tag to a 2-column \table because the \image
would otherwise break the table, and also because it saves space and
acts as a meaningful reminder to have the animation right under the
enum value that is being documented.

Task-number: QTBUG-70397
Task-number: QTBUG-73262
Task-number: QTBUG-100534
Task-number: QTBUG-107239
Task-number: QTBUG-111310
Change-Id: I1ff45f58a8a8edf55f4a8696d881aa9e0bedcfe3
Reviewed-by: Oliver Eftevaag <[email protected]>
(cherry picked from commit a6e196c)
Reviewed-by: Shawn Rutledge <[email protected]>

Animated gifs were captured with byzanz-record, then converted to webp:
gif2webp -lossy -min_size -q 40 -m 6 -mt -metadata none in.gif -o out.webp

Fixes: QTBUG-96915
Change-Id: Iee2f4ef774de7862d93c7e4cdf7b2b5e0553bec4
Reviewed-by: Oliver Eftevaag <[email protected]>
Reviewed-by: Doris Verria <[email protected]>
(cherry picked from commit 0247942)
Reviewed-by: Shawn Rutledge <[email protected]>

Many of the inherited docs were inappropriate or insufficiently specific
to PointHandler. Now we have more snippets with more ideas for how it
can be used.

As a drive-by, fix a typo in the docs for
PointerDeviceHandler::acceptedPointerTypes and add a link to the new
PointerDevice page added in e283c05

Fixes: QTBUG-74020
Fixes: QTBUG-106878
Change-Id: I028e1577ac5d4ef0b927c94259d6ab25b6028885
Reviewed-by: Doris Verria <[email protected]>
(cherry picked from commit 4c6d0b2)
Reviewed-by: Shawn Rutledge <[email protected]>

Amends outdated stuff from 507efe5 and
c248a32. "eventPoint" should now always
link to docs added in b43a873.

Replace the phrase "event point" with a link to the QML eventPoint
value type.

QPointingDevice is called PointerDevice in QML, so the GrabTransition
enum ought to be found in those docs, in theory, for use in the
PointerHandler::grabChanged doc.

Task-number: QTBUG-102160
Task-number: QTBUG-104761
Change-Id: I5d1a8dedd9d98e6dee3fbca457aa38f42ea7bfb1
Reviewed-by: Andreas Eliasson <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 60ebb04)
Reviewed-by: Shawn Rutledge <[email protected]>

We cannot assume anything about the accumulator register after calling
PushCallContext::call(). Also add a note about not needing to re-load
the accumulator on ThrowException.

Fixes: QTBUG-111935
Change-Id: I7196585e1d2697c215f4fe87d8d7ac9b98b622a3
Reviewed-by: <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Fabian Kosmale <[email protected]>
(cherry picked from commit 15ec024)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>

…droid"

This reverts commit 24fedb7.

Reason for revert: the test gesturePolicyDragWithinBounds doesn't exist in 6.2

Change-Id: I66859ad52f1864643f86dc4ad54d44c95b3d7a0e
Reviewed-by: Ivan Solovev <[email protected]>

Fixes: QTBUG-111577
Change-Id: I7f259c3b710d0be16844d159e3204ee2e51f2a06
Reviewed-by: Fabian Kosmale <[email protected]>
Reviewed-by: Sze Howe Koh <[email protected]>
(cherry picked from commit f0f274e)