Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtSpiAdaptor: sync Cache signatures to at-spi2-core 2.45.91 #77

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ydirson
Copy link

@ydirson ydirson commented Sep 12, 2022

Those signatures are the ones used by Gtk for some time now. For Qt it does not make a huge difference, as GetItem returns an empty list and the signals are never emited.

The Cache.xml copy had to include a workaround: adding back the direction on signal args, without which qdbusxml2cpp.cpp seems to mistake those for direction="out" and requests "Out0" annotations.

Signed-off-by: Yann Dirson [email protected]

Those signatures are the ones used by Gtk for some time now.  For Qt
it does not make a huge difference, as GetItem returns an empty list
and the signals are never emited.

The Cache.xml copy had to include a workaround: adding back the
direction on signal args, without which qdbusxml2cpp.cpp seems to
mistake those for direction="out" and requests "Out0" annotations.

Signed-off-by: Yann Dirson <[email protected]>
@jonaski
Copy link
Contributor

jonaski commented Oct 25, 2022

Qt doesn't use GitHub, this needs to be submitted to Gerrit codereview (https://codereview.qt-project.org/). For instructions see: https://wiki.qt.io/Setting_up_Gerrit and https://wiki.qt.io/Gerrit_Introduction

langlor-autodesk added a commit to autodesk-forks/qtbase that referenced this pull request Feb 6, 2023
* Windows: use QSystemLibrary instead of LoadLibrary directly

Using QSystemLibrary ensures that it will only use the expected copy of
the system library and not one that has been placed in the application's
working directory or elsewhere in the PATH environment variable.

Pick-to: 5.15 6.2 6.3
Change-Id: Ic4234334f73482b38ee5f06345bf11f8c029edc5
Reviewed-by: Laszlo Agocs <[email protected]>
Reviewed-by: Thiago Macieira <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>

* Windows: use QSystemLibrary instead of LoadLibrary directly (5.15)

This is the rest of the patch that is specific to Qt 5.15.

Using QSystemLibrary ensures that it will only use the expected copy of
the system library and not one that has been placed in the application's
working directory or elsewhere in the PATH environment variable.

Change-Id: Ic559957f5ca2e53193a1c230577f877b09e90859

Co-authored-by: Andy Shaw <[email protected]>
Co-authored-by: Keith Kyzivat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants