Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDir::listSeparator() and make windeployqt work in linux-mingw. #63

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

socketpair
Copy link

No description provided.

@@ -1648,7 +1648,7 @@ int main(int argc, char **argv)
const QByteArray qtBinPath = QFile::encodeName(QDir::toNativeSeparators(QCoreApplication::applicationDirPath()));
QByteArray path = qgetenv("PATH");
if (!path.contains(qtBinPath)) { // QTBUG-39177, ensure Qt is in the path so that qt.conf is taken into account.
path += ';';
path += QDir::listSeparator();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is the BUG. THis bug fixes windeployqt under linux.

Please tell me how can I make the fix for Qt 5.15.x ? is it possible ?

@socketpair
Copy link
Author

Sorry, guys, I did not even try to build. Possibly this does not compile. Please review.

@jonaski
Copy link
Contributor

jonaski commented Oct 25, 2022

Qt doesn't use GitHub, this needs to be submitted to Gerrit codereview (https://codereview.qt-project.org/). For instructions see: https://wiki.qt.io/Setting_up_Gerrit and https://wiki.qt.io/Gerrit_Introduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants