Update journal-entry.qml #251
Conversation
Fixed these 2 issues: 1. On the 1<sup>st</sup> and 2<sup>nd</sup> lines respectively the real file name is added,underlined with === 2. the word _Note:_ followed by a long aplhanumeric code that changes to the real name by moving to another note and back.
|
|
||
| // Create the new journal note without the filename and empty line. | ||
| // Create the new journal note with only the body template content - code line shortened by ChatGPT. | ||
| script.createNote(noteBodyTemplate); |
There was a problem hiding this comment.
There are three descriptions for this line now. Which one of them is the right one?
There was a problem hiding this comment.
And you removed the headline, was this intentional?
There was a problem hiding this comment.
lines 167 and 168 are the original ones, and should be deleted.
lines 168 and 169 in effect are the same. So, we could rephrase it as:
// Create the new journal note with only the body template content (= without the filename and empty line).
Removing the headline was intentional because I don't want the file name of the note repeated in the note itself, I never do that. Now this is something particular to me, and I understand you may want to keep it. In that case I will use my version of the .qml file.
There was a problem hiding this comment.
lines 167 and 168 are the original ones, and should be deleted.
lines 168 and 169 in effect are the same. So, we could rephrase it as
Can you please delete the lines if they shouldn't be part of the script anymore? 😊
Removing the headline was intentional because I don't want the file name of the note repeated in the note itself, I never do that.
Ok, the headline generation is an integral part of the script. We would need a script setting to allow/disallow adding of the headline rather than just removing the code.
There was a problem hiding this comment.
You marked this as resolved, but you didn't change anything. Was this an accident?
There was a problem hiding this comment.
No, it was not an accident, I thought I was done. So what is required now?
There was a problem hiding this comment.
For the 2nd part: If you don't want to / can't create a setting, please add the removed code again.
|
But since you already have two open pull requests, be sure you are doing all future commits for this pull request in your |
|
I assume the ball is in your court now: approval. |
|
Approval of what? |
|
This, as shown above:
|
Fixed these 2 issues: