mandate columns when constructing DataGrid

qooxdoo · May 30, 2024 · 2fd7bb3 · 2fd7bb3
1 parent d7a2127
commit 2fd7bb3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/source/class/qxl/datagrid/DataGrid.js b/source/class/qxl/datagrid/DataGrid.js
@@ -35,19 +35,19 @@ qx.Class.define("qxl.datagrid.DataGrid", {
    */
   construct(columns, styling) {
     super();
+    if (!columns) {
+      throw new Error("Columns must be provided!");
+    }
     this.__debounceUpdateWidgets = new qxl.datagrid.util.Debounce(() => this.updateWidgets(), 50);
     this.__selectionManager = new qxl.datagrid.ui.SelectionManager();
     this.__selectionManager.addListener("changeSelection", evt => {
       this.scheduleUpdateWidgets();
       this.fireDataEvent("changeSelection", evt.getData(), evt.getOldData());
     });
 
-    columns = columns || null;
     styling = styling || new qxl.datagrid.ui.GridStyling();
     this.__sizeCalculator = new qxl.datagrid.ui.GridSizeCalculator(columns, styling, this);
-    if (columns) {
-      this.setColumns(columns);
-    }
+    this.setColumns(columns);
 
     this.getQxObject("widgetPane").addListener("modelDoubleTap", evt => this.fireDataEvent("modelDoubleTap", evt.getData()));