Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-cli-addon-docs dependency so does not error #383

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

mrloop
Copy link
Contributor

@mrloop mrloop commented Sep 7, 2022

Description

ember-cli-addon-docs requires ember-data. Removed previously #380

ember-learn/ember-cli-addon-docs#818

Reproduction instructions

Run yarn && yarn ember s and check docs

@mrloop mrloop self-assigned this Sep 7, 2022
@mrloop mrloop added bug Something isn't working dependencies Pull requests that update a dependency file documentation labels Sep 7, 2022
ember-cli-addon-docs requires ember-data. Removed previously
#380

ember-learn/ember-cli-addon-docs#818
@mrloop mrloop merged commit 83fe131 into master Sep 7, 2022
@mrloop mrloop deleted the em-docs branch September 7, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants