-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add const checking for non-dynamic evolution #371
Conversation
May we make the error message a bit more detailed? I am imagining an unexperienced undergrad that has not read the documentation very thoroughly. Maybe something along the lines of: "You are attempting to use a time-dependent dynamics generator (a Hamiltonian or Lindbladian) with a solver that assumes constant dynamics. To avoid errors, please use the Longer term, I am wondering why is there an error at all if we already know what should actually happen. Should we just dispatch to the correct solver if we detect Otherwise, looks good to me (presumably after the is_const fixes get merged to QOBase.jl). |
Yeah, I agree we should probably just "do the right thing" longer term and not require the "dynamic" methods. We could just add appropriate |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 97.82% 97.80% -0.02%
==========================================
Files 18 18
Lines 1516 1550 +34
==========================================
+ Hits 1483 1516 +33
- Misses 33 34 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should be ready now @Krastanov @ChristophHotter |
LGTM. I assume the repeated definition of |
Yeah, that's the only reason. |
No description provided.