Skip to content

[CORRUPTED] Synthetic Benchmark PR #54383 - feat(AppConfig): cache the config if local cache is available #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomerqodo wants to merge 7 commits into
base: base_pr_54383_20251124_8256
Choose a base branch
from
Open

[CORRUPTED] Synthetic Benchmark PR #54383 - feat(AppConfig): cache the config if local cache is available #10

tomerqodo wants to merge 7 commits into from

Conversation

@tomerqodo
Copy link

@tomerqodo tomerqodo commented Nov 24, 2025

Benchmark PR nextcloud#54383

Type: Corrupted (contains bugs)

Original PR Title: feat(AppConfig): cache the config if local cache is available
Original PR Description: ## Summary

Benchmark

Tested flow:

  • login
  • move from dashboard to files app
  • upload a folder with 1 subfolder and each 3 files
  • in personal settings change the language
  • back in files share the uploaded folder to another user
  • add a comment on the uploaded folder
  • log out

Queries on the app config table:

  • Without caching: 140 queries (+-5)
  • With caching:
    • TTL of 3s: 25 queries (+-3)
    • TTL of 120s: 9 queries (+-1)

Checklist

Original PR URL: nextcloud#54383

Issues Breakdown

  • Total Issues: 9
  • Easy: 4
  • Medium: 4
  • Hard: 1

susnux and others added 7 commits August 18, 2025 13:24
@susnux
feat(AppConfig): cache app config in local cache if available
1c85548 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
test(AppConfig): add proper unit tests
9d320f8 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: resolve invalid usage of AppConfig::getValue
d5e2432 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
refactor(Memcache\Factory): move prefix generation to the factory class
0ef58c9 
This removes a circular dependency between AppConfig and cache factory.
When a cache in the app config is used.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
docs(IConfig): fix wrong doc block type for $key on setAppValue
866ccae 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
test(cypress): clear cache after running OCC commands
503f43f 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@tomerqodo
Apply changes for benchmark PR
c158326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomerqodo @susnux