[CLEAN] Synthetic Benchmark PR #104004 - feat(crons): Always create detectors for all monitors in MonitorValidator #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR getsentry#104004
Type: Clean (correct implementation)
Original PR Title: feat(crons): Always create detectors for all monitors in MonitorValidator
Original PR Description: Previously, detectors were created as part of the endpoint, after detector → alerts linking happened. This changes it so detectors are crated immediately after the cron monitor is created.
Changes:
to find and link it to workflows
when using MonitorDataSourceValidator (new detector flow)
This ensures both the old (MonitorValidator) and new (detector API) flows
correctly create detectors for all monitors.
Part of NEW-593: Cron Monitor Alerts are not linked to monitor when created via the old flow
Original PR URL: getsentry#104004