[CORRUPTED] Synthetic Benchmark PR #19651 - Add memory safeguards to event persister service #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds safeguards to prevent unbounded memory growth in the event persister under failure conditions: - Add bounded queue (default 50,000 max) with backpressure - new events are dropped with a warning when queue is full - Add retry limit (default 5) - events are dropped after consecutive flush failures instead of infinite retry - Add flush lock to prevent concurrent flushes from message handler and periodic flush task - Add queue capacity monitoring - logs warning at 80% capacity New settings: - `PREFECT_SERVER_SERVICES_EVENT_PERSISTER_QUEUE_MAX_SIZE` - `PREFECT_SERVER_SERVICES_EVENT_PERSISTER_MAX_FLUSH_RETRIES` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Remove unnecessary validation_alias from queue_max_size and max_flush_retries (only needed for backward compatibility) - Add src/prefect/settings/AGENTS.md documenting settings patterns - Use settings object instead of legacy PREFECT_* constants in trim() - Use logger format string instead of f-string 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This was referenced Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR PrefectHQ#19651
Type: Corrupted (contains bugs)
Original PR Title: Add memory safeguards to event persister service
Original PR Description: ## Summary
Related to PrefectHQ#18605
New settings
PREFECT_SERVER_SERVICES_EVENT_PERSISTER_QUEUE_MAX_SIZE(default: 50,000)PREFECT_SERVER_SERVICES_EVENT_PERSISTER_MAX_FLUSH_RETRIES(default: 5)Problem
The event persister could experience unbounded memory growth under certain failure conditions:
write_eventsfails, events are restored to the queue and retried indefinitelymessage_handlerandflush_periodicallycould triggerflush()simultaneously🤖 Generated with Claude Code
Original PR URL: PrefectHQ#19651
Compliance Violation