double checked locking

qmuntal · Jul 24, 2023 · 7bc2a0b · 7bc2a0b
1 parent 143dfc7
commit 7bc2a0b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/statemachine.go b/statemachine.go
@@ -309,10 +309,13 @@ func (sm *StateMachine) stateRepresentation(state State) *stateRepresentation {
 	sr, ok := sm.stateConfig[state]
 	sm.stateMutex.RUnlock()
 	if !ok {
-		sr = newstateRepresentation(state)
 		sm.stateMutex.Lock()
-		sm.stateConfig[state] = sr
-		sm.stateMutex.Unlock()
+		defer sm.stateMutex.Unlock()
+		// Check again, since another goroutine may have added it while we were waiting for the lock.
+		if sr, ok = sm.stateConfig[state]; !ok {
+			sr = newstateRepresentation(state)
+			sm.stateConfig[state] = sr
+		}
 	}
 	return sr
 }