Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust keymap view #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adjust keymap view #12

wants to merge 2 commits into from

Conversation

arakashic
Copy link

@arakashic arakashic commented Oct 24, 2024 •
edited
Loading

Description

This PR add two adjustment to the keymap view.

  1. The height of keymap panel is calculated with a unit of 3rem, which is too small to display the entire keymap when unit size for keys is 5rem. This PR increase it to 6rem.

BEFORE
Screenshot 2024-10-24 at 12 06 16 AM
AFTER
Screenshot 2024-10-24 at 12 05 44 AM

  1. The gap between 1u and larger keys are nonuniform. This PR changes the key size calculation based on unit size (layout.w * 5rem) minus the fixed gap (0.5rem). I also added a 0.25 margin around the key to make the key aligned in the center.

BEFORE
Screenshot 2024-10-24 at 12 04 05 AM
AFTER
Screenshot 2024-10-24 at 12 03 36 AM

@arakashic
Increase keymap/layer panel height
f16d2e3 
The keymap panel height was calculated using multiples of 3rem which
is too small for key height of 5rem. Increase to 6rem to fit the entire
keymap.
@arakashic
adjust key size in keymap view for uniform keygaps
8e3910e 
The key size need to be calculated using unit size (5rem) minus the
gap between keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arakashic