Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privileged mode and usb mount for devcontainer #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

privileged mode and usb mount for devcontainer #26

wants to merge 1 commit into from
+7 −1

Conversation

saesh
Copy link

@saesh saesh commented Jun 30, 2024 •
edited
Loading

Changes

  • run devcontainer in privileged mode
  • mount /dev/bus/usb to devcontainer

Enables qmk-dfu to detect keyboard in bootloader mode inside the devcontainer.

@zvecr
Copy link
Member

zvecr commented Jun 30, 2024

Wont this change break opening in codespaces?

@saesh
Copy link
Author

saesh commented Jun 30, 2024

Wont this change break opening in codespaces?

Oh, I don't know. I only tested it locally.

As an alternative I could comment it out in the devcontainer.json and add a comment explaining the use case?

@qmk qmk deleted a comment from Qua315 Sep 5, 2024
@qmk qmk deleted a comment from Qua315 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saesh @zvecr @tzarc