Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bit count calculation for iterating layers #5912

Merged
merged 1 commit into from
May 18, 2019
Merged

Fix bit count calculation for iterating layers #5912

merged 1 commit into from
May 18, 2019

Conversation

XScorpion2
Copy link
Contributor

@XScorpion2 XScorpion2 commented May 18, 2019 •
edited
Loading

Description

Fix for bug introduced in #3637
sizeof returns size of the data structure in bytes, and this logic needs size in bits.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and confirmed as fixing this issue.

@drashna
Copy link
Member

drashna commented May 18, 2019

Odd that I never had any issues when testing this...

But thanks!

@drashna drashna merged commit ba26736 into qmk:master May 18, 2019
@XScorpion2 XScorpion2 deleted the bugfix/fixing_layer_iteration branch May 18, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XScorpion2 @drashna @noroadsleft