Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new keyboard atset/atr1 #24721

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

adding new keyboard atset/atr1 #24721

wants to merge 24 commits into from

Conversation

anubhavd7
Copy link
Contributor

Description

Types of Changes

  • [x ] Core
  • Bugfix
  • [x ] New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • [ x] Keymap/layout (addition or update)
  • [ x] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 16, 2024
@zvecr zvecr removed the via Adds via keymap and/or updates keyboard for via support label Dec 16, 2024
keyboards/atset/atr1/info.json Outdated Show resolved Hide resolved
keyboards/atset/atr1/info.json Show resolved Hide resolved
keyboards/atset/atr1/keymaps/default/keymap.json Outdated Show resolved Hide resolved
keyboards/atset/atr1/r1/readme.md Outdated Show resolved Hide resolved
Comment on lines 8 to 11
* Hardware Supported:

* ATR1 R1 *(ft. STM32F103)*
* Hardware Availability:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link to where this keyboard can be purchased under the Hardware Availability section.

Suggested change
* Hardware Supported:
* ATR1 R1 *(ft. STM32F103)*
* Hardware Availability:
* Hardware Supported: ATR1 R1 PCB with STM32F103
* Hardware Availability:

keyboards/atset/atr1/readme.md Outdated Show resolved Hide resolved
@anubhavd7 anubhavd7 requested a review from waffle87 December 17, 2024 12:46
@waffle87
Copy link
Member

There are still outstanding suggestions. Please do not mark things as resolved without acknowledging them. This has been an issue on your previous PR's as well.

@waffle87
Copy link
Member

Please provide a link to where this keyboard can be purchased under the Hardware Availability section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants