-
-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHKB YDKB Yang BT Controller #11011
HHKB YDKB Yang BT Controller #11011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd rather have this implementation under keyboards/hhkb/yang
than in its own directory.
Thank you, @jram0421, for opening the pull request. @Erovia I was thinking about to put the directory under Your other suggestions for flashing is great. I'll update them. @drashna I opened #10674 a while ago to discuss how to structure the BLE code. If can go ahead and separate the bits to a separate PR and have discussion there. |
Currently everything under |
I'd love to see this in |
Based on the explanation https://github.com/tomsmalley/custom-topre-guide
…pt handler The UART reader uses reciving interrupt so cannot be used inside another interrupt handler, e.g. USB wakeup.
Addressed all the comments and extracted the Adafruit UART code to separate PR here #11403 |
@kanru The Yang docs mention the ability to output the battery percentage as text, which is bound to |
yes, it's totally possible. It's very easy to implement via extra commands or user commands. I have a local change in my keymap does just that. Let me push the commit in a bit. |
ping? |
@kanru how long does your battery last with qmk? I'm down to like 4-5 days using a 2000mAh battery. |
About 3-4 days (using 8~9 hours per day) using a 1200mAh battery. I think it can still be optimized to double or triple the use time but I don't have a oscilloscope yet so my ability to troubleshoot is limited. I suspect the current sleep state in qmk is not deep or long enough, after all it was for usb power saving. |
Bump again |
Keyboard Maintainer: [Kan-Ru Chen](https://github.com/kanru) | ||
Hardware Supported: YANG HHKB BLE Controller | ||
Hardware Availability: https://kbdfans.com/products/hhkb-ble-mod-upgrade-module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this section as a list is preferred.
Keyboard Maintainer: [Kan-Ru Chen](https://github.com/kanru) | |
Hardware Supported: YANG HHKB BLE Controller | |
Hardware Availability: https://kbdfans.com/products/hhkb-ble-mod-upgrade-module | |
* Keyboard Maintainer: [Kan-Ru Chen](https://github.com/kanru) | |
* Hardware Supported: YANG HHKB BLE Controller | |
* Hardware Availability: https://kbdfans.com/products/hhkb-ble-mod-upgrade-module |
# Disable debounce | ||
DEBOUNCE = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs to be set in config.h
(as #define DEBOUNCE 0
) rather than here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Correct. In the rules file, it won't actually do anything.
Though, leaving it undefined will also set it to 0.
Thank you for your contribution! |
Thank you for your contribution! |
Bump, it would be nice to have this merged |
Bump, has this been merged yet? |
Extra command is defined to force a BT repair by You can also define keybindings in your keymap. For example:
It was limited by the Adafruit firmware on the BT module, which only supports one bonded device. So you'll need to reconnect until the correct device is selected. TBH I'm not sure when this will be merged, it's been so long. Feel free to use or submit PR to my fork. Due to the limitation of the Adafruit firmware mentioned above and wanting to have a more open hardware I have switched to a hand wired nice!nano board and custom ZMK build. I'm very happy with the new setup. Both the board and the firmware are fully open source, more power efficient (up to 15 days usage with a 1200 mAh battery), ZMK is a real RTOS and supports virtually unlimited bonded devices. I plan to also release the new setup this year. |
I'd recommend reopening this PR, if you're still up to it. Also, I've recently created a PR to collect known YDKB boards in a directory #15681 , you might want to check that out if you decide to reopen this PR |
Description
Adds support for the Yang controller for HHKB Pro 2.
Types of Changes
Issues Fixed or Closed by This PR
Checklist