Run installer as regular user #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the installer as admin means that the default installation folder is the admin's appdata folder, where the user that started the installation cannot access it. The required admin privileges were introduced to allow the qmk_driver_installer.exe to run. Run the installer as a regular user and run qmk_driver_installer.exe using shellexec to get a UAC prompt only when it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this great project!
Running the installer as admin means that the default installation folder is the admin's appdata folder. Even when installing into a user-owned location, I can only run the WSL shortcut as Admin.
As I understand it, the required admin privileges were introduced to allow the
qmk_driver_installer.exeto run.This change runs the installer as a regular user and run qmk_driver_installer.exe using
shellexecto get a UAC prompt only when it is needed.