feat: add support for configDir #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibautMarechal
commented
Oct 29, 2024
src/utils.ts
Outdated
| @@ -26,8 +26,8 @@ export function normalizePath(id: string): string { | |||
| return posix.normalize(slash(id)) | |||
| } | |||
|
|
|||
| export function resolve(...paths: string[]) { | |||
| return normalizePath(_resolve(...paths)) | |||
| export function resolve(root: string, path: string) { | |||
There was a problem hiding this comment.
Honestly, I'm not sure if it's the right place, or if I should add one more helper function to do that.
But this implementation work for my use case where I use ${configDir} in include, exclude, basePath, outDir.
Let me know if you think I should do it differently
There was a problem hiding this comment.
@qmhc, any suggestion?
I'm currently waiting this fix to remove a bunch of workaround on my side.
Open to any feedback :)
There was a problem hiding this comment.
I think the general utility methods should not be modified. There should be a dedicated step to handle this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346