Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substitute RCPP_UNORDERED_MAP with std::unordered_map #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Enchufa2
Copy link

Dear jiebaR maintainer,

As part of the effort to clean up old code and set C++11 as the baseline standard for Rcpp (see RcppCore/Rcpp#1365), we identified that this package is using RPP_UNORDERED_MAP, and we would like to suggest substituting this define with the proper std::unordered_map type. In this way, we would be able to remove this unnecessary define without breaking your package on CRAN.

We would appreciate if you could merge this PR and send an update to CRAN at your earliest convenience.

Thanks,
On behalf of the Rcpp Core Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant