Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: landing and login #9

Merged
merged 29 commits into from
Aug 26, 2023
Merged

feat: landing and login #9

merged 29 commits into from
Aug 26, 2023

Conversation

qin-guan
Copy link
Owner

Landing page would probably be onboarding screen, hmmm.

@qin-guan qin-guan marked this pull request as draft August 24, 2023 10:19
Copy link
Collaborator

@julwrites julwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't quite tell where the routing happens, but maybe i'm missing it? Or does it get handled somewhere outside of the code?

components/onboarding/Setup.client.vue Outdated Show resolved Hide resolved
components/onboarding/Setup.client.vue Outdated Show resolved Hide resolved
components/onboarding/Setup.client.vue Outdated Show resolved Hide resolved
@qin-guan
Copy link
Owner Author

I think the auto imports are still manageable for me because I'm used to it. But we can turn it off as well, lmk? @julwrites

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1315113
Status: ✅  Deploy successful!
Preview URL: https://d79a2536.cash-register-3az.pages.dev
Branch Preview URL: https://feat-landing-and-login.cash-register-3az.pages.dev

View logs

@julwrites
Copy link
Collaborator

I think the auto imports are still manageable for me because I'm used to it. But we can turn it off as well, lmk? @julwrites

Yeah i think that would help me better trace and understand the code.

@qin-guan
Copy link
Owner Author

Okay I think we can track auto import progress in a separate issue

@qin-guan
Copy link
Owner Author

#10

@qin-guan qin-guan marked this pull request as ready for review August 26, 2023 09:11
@qin-guan
Copy link
Owner Author

Okay I think the functionality is more or less complete

@qin-guan
Copy link
Owner Author

Also includes upgrade to Nuxt 3.7, but should not introduce any breaking changes

@qin-guan
Copy link
Owner Author

Seems like Cloudflare complains about exceeding CPU limits for a while after the 3.7 upgrade deployment but I cant repro it anymore, hmmmmm... just writing it down in case it complains about it in the future

@qin-guan qin-guan merged commit 07123ca into main Aug 26, 2023
2 checks passed
@qin-guan qin-guan deleted the feat/landing-and-login branch August 26, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants