MAINT: qiime2 -> rachis migration #1003
Conversation
|
Another note: this PR will fail, not for any interesting reason (bc multiple distros are being updated at once). I wanted to do all of this at once to keep things isolated to one PR. We will inevitably need to see if anything breaks once this gets merged, but my hope is that if this gets done all at once early on in our development cycle there will be plenty of time to fix it before the 2026.1 release. |
| rebuilt-channel-key: ${{ needs.prepare.outputs.rebuilt-channel-key }} | ||
| patched-channel-key: ${{ needs.prepare.outputs.patched-channel-key }} | ||
| distro-name: qiime2-${{ needs.prepare.outputs.distro }} | ||
| distro-name: rachis-${{ needs.prepare.outputs.distro }} |
There was a problem hiding this comment.
Irrespective of the final distro name, I wonder if we should pull the prefix out entirely?
This would take a lot to do though, since it has unfortunately accreted a lot of dependencies (3rd party actions, library, etc). But I've been kind of unhappy with the prefix for a while. (e.g. "moshpit" should just be "moshpit", so in that sense, "rachis" is more neutral, but I wonder if we want this going into the future.)
There was a problem hiding this comment.
(for posterity, we already discussed on basecamp- but adding here as well)
yeah i think the amount of dependencies we have on the env file name structure makes the removal of the prefix more involved than just a simple swap. while i do think the cleanest outcome would be -etc without any prefix, i'm not sure if the juice is worth the squeeze. mainly bc i think rachis--etc conveys that this environment file uses rachis as the base, which makes it pretty clear where this is coming from.
| image: ${{ steps.build-galaxy-image.outputs.image }} | ||
| tags: ${{ steps.build-galaxy-image.outputs.tags }} | ||
| registry: quay.io/qiime2 | ||
| registry: quay.io/rachis |
There was a problem hiding this comment.
This will break our tools repo and q2galaxy since they expect it from qiime2.
| image: ${{ steps.build-workshop-image.outputs.image }} | ||
| tags: ${{ steps.build-workshop-image.outputs.tags }} | ||
| registry: quay.io/qiime2 | ||
| registry: quay.io/rachis |
There was a problem hiding this comment.
I think we should dual-publish for a little bit, so that there is time to migrate.
| @@ -1,5 +1,5 @@ | |||
| channels: | |||
| - https://packages.qiime2.org/qiime2/2026.1/amplicon/passed | |||
| - https://packages.qiime2.org/qiime2/2026.1/qiime2/passed | |||
There was a problem hiding this comment.
Should we symlink the first qiime2 in this URL to rachis?
- https://packages.qiime2.org/rachis/2026.1/qiime2/passed
This PR does the following:
Note that the following external changes have also been made to accompany this PR:
Paired ALP PR: qiime2/action-library-packaging#58