Add translation for redlining draw layer #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugins/map/RedliningSupport.jsx
Outdated
| @@ -22,6 +22,7 @@ | |||
| import FeatureStyles from '../../utils/FeatureStyles'; | |||
| import MapUtils from '../../utils/MapUtils'; | |||
| import MeasureUtils from '../../utils/MeasureUtils'; | |||
| import LocaleUtils from '../../utils/LocaleUtils'; | |||
Check failure
Code scanning / ESLint
enforce sorted imports Error
manisandro
reviewed
Jul 12, 2024
| @@ -574,7 +575,7 @@ class RedliningSupport extends React.Component { | |||
| feature.crs = this.props.mapCrs; | |||
| const layer = { | |||
| id: this.props.redlining.layer, | |||
| title: this.props.redlining.layerTitle, | |||
| title: LocaleUtils.tr(this.props.redlining.layerTitle), | |||
There was a problem hiding this comment.
This line here is incorrect, layerTitle is already translated (see line 81 in Redlining.jsx).
There was a problem hiding this comment.
I belived too, but if I do not use it here it goes back to it's untranslated state as soon as you add a point or anything in the layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @manisandro,
I would like to submit this PR because I received feedback from many users who don't understand why the default redlining layer is named like this, even in other languages. It can be confusing for people who don't understand basic English.
So, this PR aims to use the translation tools to name the layer according to the user's browser language. I hope the code is correct, but please let me know if it isn't.
Thanks in advance,
Regards, Clément.