Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): simplify JSON schema of job qgis-finder #601

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(docs): simplify JSON schema of job qgis-finder #601

merged 1 commit into from
Dec 13, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Dec 13, 2024 •
edited
Loading

Following up of #600

Before:

after PR #600

  • the schema does not matches structure, so validation is not really working
  • it's "visible" with missing tooltip when over on keywords

After this PR:

See visible tooltips when mouse hover

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 13, 2024
@Guts Guts force-pushed the docs/json-schema-qgis-finder branch from ff597fc to 1cb81bf Compare December 13, 2024 17:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Guts Guts mentioned this pull request Dec 13, 2024
Closed
@Guts Guts linked an issue Dec 13, 2024 that may be closed by this pull request
[BUG]: TypeError: Options to validate must be a dict, not <class 'list'> #599
Closed
1 task
@Guts Guts added the bug Something isn't working label Dec 13, 2024
@Guts Guts marked this pull request as ready for review December 13, 2024 17:49
@Guts Guts merged commit cb99e2f into main Dec 13, 2024
7 checks passed
@Guts Guts deleted the docs/json-schema-qgis-finder branch December 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: TypeError: Options to validate must be a dict, not <class 'list'>
1 participant
@Guts