-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(proxies): define environment variable for proxy use for git clone #584
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 70.43% 70.35% -0.08%
==========================================
Files 47 47
Lines 3162 3188 +26
Branches 554 558 +4
==========================================
+ Hits 2227 2243 +16
- Misses 741 747 +6
- Partials 194 198 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing and too generic docstring.
- define wrapper for environment variable definition and backup - use wrapper for all function using porcelain for git command
for more information, see https://pre-commit.ci
9d23214
to
cfda597
Compare
Quality Gate passedIssues Measures |
When a proxy is needed for git clone,
dulwich
and high level interfaceporcelain
only use environment variable for proxy definition :HTTP_PROXY
/HTTPS_PROXY
In this PR we are :