Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed async_grpc #866

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Removed async_grpc #866

wants to merge 4 commits into from

Conversation

I8dNLo
Copy link

@I8dNLo I8dNLo commented Dec 17, 2024

All Submissions:

  • [ *] Contributions should target the dev branch. Did you create your branch from dev?
  • [ *] Have you followed the guidelines in our Contributing document?
  • [ *] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [ *] Does your submission pass tests?
  2. [ *] Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • [ *] Have you successfully ran tests with your changes locally?

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit cedce3f
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/676333e4308b650008f89fa4
😎 Deploy Preview https://deploy-preview-866--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@I8dNLo I8dNLo requested a review from joein December 17, 2024 12:38
Copy link
Member

@joein joein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qdrant remote now contain an unused import get_async_channel, if we remove it - the generator breaks, we need to remove it and update the generator

@joein
Copy link
Member

joein commented Dec 18, 2024

asyncio and all the related code should be removed from QdrantRemote

if hasattr(self, "_aio_grpc_channel") and self._aio_grpc_channel is not None:
    try:
        loop = asyncio.get_running_loop()
        loop.create_task(self._aio_grpc_channel.close(grace=grpc_grace))
    except AttributeError:
        logging.warning(
            "Unable to close aio_grpc_channel. Connection was interrupted on the server side"
        )
    except RuntimeError:
        pass

this code should be removed as well, the generator should be updated to take this removals into account

tests/test_qdrant_client.py Outdated Show resolved Hide resolved
@joein joein self-requested a review December 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants