Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: add local_files_only propagation to fastembed mixin #746

Closed
wants to merge 2 commits into from

Conversation

joein
Copy link
Member

@joein joein commented Aug 20, 2024

No description provided.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 2a45e35
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/66c47c2a48083c0008027877
😎 Deploy Preview https://deploy-preview-746--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein
Copy link
Member Author

joein commented Aug 20, 2024

#743

@joein joein requested a review from I8dNLo August 20, 2024 12:19
I8dNLo
I8dNLo previously approved these changes Oct 2, 2024
@joein joein requested a review from I8dNLo October 3, 2024 11:37
@joein
Copy link
Member Author

joein commented Oct 3, 2024

Unfortunately, it is broken:

Traceback (most recent call last):
  File ".../qdrant/qdrant_client/checks.py", line 3, in <module>
    cl = QdrantClient(local_files_only=True)
  File ".../qdrant/qdrant_client/qdrant_client/qdrant_client.py", line 134, in __init__
    self._client = QdrantRemote(
  File ".../qdrant/qdrant_client/qdrant_client/qdrant_remote.py", line 168, in __init__
    self.openapi_client: SyncApis[ApiClient] = SyncApis(
  File ".../qdrant/qdrant_client/qdrant_client/http/api_client.py", line 36, in __init__
    self.client = ApiClient(host, **kwargs)
  File ".../qdrant/qdrant_client/qdrant_client/http/api_client.py", line 60, in __init__
    self._client = Client(**kwargs)
TypeError: Client.__init__() got an unexpected keyword argument 'local_files_only'

@joein joein dismissed I8dNLo’s stale review October 3, 2024 11:38

The implementation is broken

@joein
Copy link
Member Author

joein commented Oct 5, 2024

already supported via set_model and set_sparse_model

@joein joein closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants