Add fastembed image models #613
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
generall
reviewed
May 8, 2024
qdrant_client/fastembed_common.py
Outdated
| @@ -10,5 +10,6 @@ class QueryResponse(BaseModel, extra="forbid"): # type: ignore | |||
| embedding: Optional[List[float]] | |||
| sparse_embedding: Optional[SparseVector] = Field(default=None) | |||
| metadata: Dict[str, Any] | |||
| document: str | |||
| document: Optional[str] = None | |||
| path: Optional[str] = None | |||
generall
reviewed
May 8, 2024
qdrant_client/qdrant_fastembed.py
Outdated
| else {} | ||
| ) | ||
|
|
||
| SUPPORTED_EMBEDDING_MODELS = { |
generall
reviewed
May 8, 2024
qdrant_client/qdrant_fastembed.py
Outdated
| @@ -37,13 +52,14 @@ | |||
| class QdrantFastembedMixin(QdrantBase): | |||
| DEFAULT_EMBEDDING_MODEL = "BAAI/bge-small-en" | |||
|
|
|||
| embedding_models: Dict[str, "TextEmbedding"] = {} | |||
| embedding_models: Dict[str, Union["ImageEmbedding", "TextEmbedding"]] = {} | |||
There was a problem hiding this comment.
let's separate into different fields
generall
reviewed
May 8, 2024
qdrant_client/qdrant_fastembed.py
Outdated
| **kwargs: Any, | ||
| ) -> "TextEmbedding": | ||
| ) -> Union["ImageEmbedding", "TextEmbedding"]: |
There was a problem hiding this comment.
also, let's use different methods
generall
reviewed
May 8, 2024
qdrant_client/qdrant_fastembed.py
Outdated
| metadata: Optional[Iterable[Dict[str, Any]]] = None, | ||
| ids: Optional[Iterable[models.ExtendedPointId]] = None, | ||
| batch_size: int = 32, | ||
| parallel: Optional[int] = None, | ||
| images: Optional[Iterable[Union[str, Path]]] = None, |
|
Let's postpone this integration jet, I might have some different idea to consider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.