Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) new: Added jina embedding v3 #428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(WIP) new: Added jina embedding v3 #428

wants to merge 1 commit into from

Conversation

hh-space-invader
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

joein
joein requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@joein joein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. tests
  2. license
  3. users can't change task id in this setting, since we are not propagating kwargs to onnx_embed, they are always hard-coded

fastembed/text/multitask_embedding.py
supported_multitask_models = [
{
"model": "jinaai/jina-embeddings-v3",
"dim": [32, 64, 128, 256, 512, 768, 1024],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not introducing matryoshka in this pr, let's make it an int?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joein joein joein requested changes

@I8dNLo I8dNLo Awaiting requested review from I8dNLo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hh-space-invader @joein