Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete sweep_helpers.py #56

Closed

Conversation

Dominik-Vogel
Copy link
Contributor

Sweep helpers seems to be outdated and superseeded by sweep_functions.py.

@ThorvaldLarsen
Copy link
Collaborator

Yes, I dont use the sweep helpers at all. However, I think maybe Natalie is still calling them from other functions.

@Dominik-Vogel
Copy link
Contributor Author

Dominik-Vogel commented Jan 16, 2018

They get called in

  • alazar_automation.py lines 237, 312
  • alazar_rs_helpers.py line 335
  • vna_helpers.py line 41
    and I would want to get rid of vna_helpers.py anyways/move it into customised instruments

@nataliejpg
Copy link
Collaborator

Yes they still get called in some of the automated functions I use. I also personally prefer the 'start', 'stop', 'step' way of defining a sweep so even though I think they should in general be replaced in wrappers I would possibly keep them around somewhere for personal use. I also don't think this is a good use of time to dig through and replace right now because I think we should work out what sort of structure we want the wrappers to have etc and then most of the code in 'transmon' will get refactored or deleted. Talk on Wednesday?

@Dominik-Vogel
Copy link
Contributor Author

Thank you @nataliejpg for pointing out the different signature with step vs num_points. I think specifying a step size could be integrated into doNd without breaking compatibility.
And I also agree, that it is not the time to do all these replacements right now. I made this PR because I found these redundant functions when going through the wrappers in preparation for tomorrow....

@nataliejpg
Copy link
Collaborator

@Dominik-Vogel oooh that sounds interesting with doNd. Great that you are looking through and seeing what there is. I have the feeling that it will get pulled apart so much that it will basically be rewritten (luckily I'm not very attached to any of the code) but I guess we'll see. Happy new year to you too

@Dominik-Vogel Dominik-Vogel changed the base branch from all_wrappers to master February 6, 2018 09:16
@nataliejpg
Copy link
Collaborator

I think that deleting the whole folder a la #156 makes more sense. @Dominik-Vogel are you fine for me to close this?

@GateBuilder GateBuilder closed this Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants