improved .calculate_p_permu

qddyy · Sep 14, 2023 · c3dfd6f · c3dfd6f
1 parent 10f3d9a
commit c3dfd6f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/R/PermuTest.R b/R/PermuTest.R
@@ -217,11 +217,11 @@ PermuTest <- R6Class(
         },
 
         .calculate_p_permu = function() {
-            l <- quote(mean(private$.statistic_permu <= private$.statistic))
-            r <- quote(mean(private$.statistic_permu >= private$.statistic))
-            lr <- quote(2 * min(eval(l), eval(r)))
+            l <- ecdf(private$.statistic_permu)(private$.statistic)
+            r <- 1 - l + 1 / length(private$.statistic_permu)
+            lr <- 2 * min(l, r, 0.5)
 
-            private$.p_value <- eval(get(private$.side))
+            private$.p_value <- get(private$.side)
         },
 
         .calculate = function() {