Parsing fails when XML declaration is missing and a standard PI is pr…

…esent (#134)
qcam · Oct 22, 2024 · adb66d2 · adb66d2
1 parent 3cc45a3
commit adb66d2
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 2 deletions.
diff --git a/lib/saxy/parser/builder.ex b/lib/saxy/parser/builder.ex
@@ -27,6 +27,9 @@ defmodule Saxy.Parser.Builder do
 
       defp prolog(<<buffer::bits>>, more?, original, pos, state) do
         lookahead(buffer, @streaming) do
+          "<?xml-" <> _rest ->
+            prolog_misc(buffer, more?, original, pos, state, [])
+
           "<?xml" <> rest ->
             xml_decl(rest, more?, original, pos + 5, state)
 

diff --git a/test/saxy/partial_test.exs b/test/saxy/partial_test.exs
@@ -11,7 +11,10 @@ defmodule Saxy.PartialTest do
   doctest Saxy.Partial
 
   @fixtures [
-    "food.xml",
+    "no-xml-decl.xml",
+    "no-xml-decl-with-std-pi.xml",
+    "no-xml-decl-with-custom-pi.xml",
+    "foo.xml",
     "food.xml",
     "complex.xml",
     "illustrator.svg",

diff --git a/test/saxy_test.exs b/test/saxy_test.exs
@@ -6,7 +6,10 @@ defmodule SaxyTest do
   doctest Saxy
 
   @fixtures [
-    "food.xml",
+    "no-xml-decl.xml",
+    "no-xml-decl-with-std-pi.xml",
+    "no-xml-decl-with-custom-pi.xml",
+    "foo.xml",
     "food.xml",
     "complex.xml",
     "illustrator.svg",

diff --git a/test/support/fixture/no-xml-decl-with-custom-pi.xml b/test/support/fixture/no-xml-decl-with-custom-pi.xml
@@ -0,0 +1,2 @@
+<?target ptr="self"?>
+<foo bar="value"></foo>
diff --git a/test/support/fixture/no-xml-decl-with-std-pi.xml b/test/support/fixture/no-xml-decl-with-std-pi.xml
@@ -0,0 +1,2 @@
+<?xml-stylesheet type="text/xsl" href="stylesheet.xsl"?>
+<foo bar="value"></foo>
diff --git a/test/support/fixture/no-xml-decl.xml b/test/support/fixture/no-xml-decl.xml
@@ -0,0 +1 @@
+<foo bar="value"></foo>