Skip to content

Conversation

@angrynode
Copy link
Contributor

I don't know how API versioning works in this project so i just bumped it here... but maybe you know in which API version it should be introduced? Or if we should bump it in code too?

I just wanted to update the docs because suddenly my API client was behaving weird when adding paused torrents and i realized they just weren't paused anymore after updating. Feel free to change whatever and merge :)

@xavier2k6
Copy link
Member

I don't know how API versioning works in this project so i just bumped it here... but maybe you know in which API version it should be introduced? Or if we should bump it in code too?

@qbittorrent/bug-handlers Please advise about "API versioning", ok to merge?

@xavier2k6
Copy link
Member

@angrynode Do you mind changing "resume" to "start" too.

Xref.: #26

@Chocobo1
Copy link
Member

@qbittorrent/bug-handlers Please advise about "API versioning", ok to merge?

It is nice that the author included an API v2.12.0 section. It is fine to merge.

@angrynode Do you mind changing "resume" to "start" too.

👍

@angrynode
Copy link
Contributor Author

Do you mind changing "resume" to "start" too.

I'm not really comfortable with this. This PR is from my own testing and reading of the code. I've tested everything, which is also why i didn't change the addPaused setting to addStopped. I'd be afraid to introduce something wrong if i go beyond.

@angrynode
Copy link
Contributor Author

Hello looks like this is still stuck and the current API is still undocumented.

What's the blocker? is that about resume->start? If so i can try and dedicate a few hours in the coming week to figure it out but i still feel like someone who followed the changes from closer would be more qualified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants