Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added date field support to Jackett #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ducalex
Copy link
Contributor

@ducalex ducalex commented Aug 6, 2024

This PR is UNTESTED. Unfortunately I'm unable to install Jackett to test (at least right now). I think it should work, but this obviously shouldn't be merged until someone tests it. I'm opening this PR just for completeness' sake, because I said I'd update as many plugins as I can :) .

I went based on Jackett's code because the API they've linked to in their README doesn't really talk about dates.

https://github.com/Jackett/Jackett/blob/eb8c3c3b8cdb1cd4fbb8d43a0af7c6b2b0bd2450/src/Jackett.Common/Models/ResultPage.cs#L45

https://github.com/Jackett/Jackett/blob/2951fcfc42865ea51bf1aaf33f8882c794a6bd70/src/Jackett.Common/Resources/test.xml

@ducalex ducalex force-pushed the ducalex/add-date-field-jackett branch from 0f6f0b9 to a175179 Compare August 6, 2024 23:53
@xavier2k6
Copy link
Member

@ngosang Please review this, as it's to do with Jackett

@ducalex Please feel free to continue submitting more PR's for outstanding plugins who don't have the date field & I will be able to test/approve.

@xavier2k6 xavier2k6 requested a review from ngosang August 7, 2024 09:42
@xavier2k6
Copy link
Member

@ducalex Do you plan to create a PR for "date field support" on limetorrents plug-in in the mean time?

@ducalex
Copy link
Contributor Author

ducalex commented Sep 12, 2024

@ducalex Do you plan to create a PR for "date field support" on limetorrents plug-in in the mean time?

I can do it but limetorrents doesn't provide good date. It shows "1 year+" for basically everything.

I thought about writing a new plugin that uses their RSS search instead (https://www.limetorrents.lol/searchrss/ubuntu/) but then we only get 50 results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants