Regenerate .ui files #21411
Merged
Regenerate .ui files #21411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
added
the
Code cleanup
Chocobo1
reviewed
Sep 29, 2024
| @@ -199,7 +199,7 @@ | |||
| </action> | |||
| <action name="actionResumeSession"> | |||
| <property name="text"> | |||
| <string>&Resume Session</string> | |||
| <string>R&esume Session</string> | |||
There was a problem hiding this comment.
Just double checking, is this change intended?
There was a problem hiding this comment.
Designer added ampersands to most (all?) such actions in this file but i reverted them all except for this one and "Shut down". This one conflicts with "Remove" action and "Shut down" conflicts with "Hibernate". With Qt 6.7.2, even in 4.6.7 (for shut down). it seems that these changes are applied automatically in runtime.
There was a problem hiding this comment.
#15658 is relevant to this I believe
|
The PR title could change to something like: "Regenerate .ui files" |
Chocobo1
approved these changes
Sep 30, 2024
glassez
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made by Designer automatically.
Closes #15658.