Fix the tab order in dialogs #21395
Merged
Fix the tab order in dialogs #21395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalieht
changed the title
thalieht
commented
Sep 27, 2024
Chocobo1
reviewed
Sep 28, 2024
Merged
|
@thalieht |
thalieht
commented
Oct 5, 2024
| <item row="3" column="0"> | ||
| <widget class="QCheckBox" name="checkExportDirFin"> | ||
| <property name="text"> | ||
| <string>Copy .torrent files for finished downloads to:</string> | ||
| </property> | ||
| </widget> | ||
| </item> | ||
| <item row="3" column="1"> | ||
| <widget class="FileSystemPathLineEdit" name="textExportDirFin" native="true"/> |
There was a problem hiding this comment.
I moved this here manually because tabstop wasn't enough to fix the order.
Chocobo1
approved these changes
Oct 6, 2024
glassez
approved these changes
Oct 6, 2024
|
@thalieht |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torrent optionsTorrent creatorPreferencesIn "torrent creator" the
tabChangesFocusproperty is not set for thetextEditfields so tab is trapped in there AFAIK. Is there any reason not to set it?The options dialog is a mess and i don't know how to fix it. e.g. inBehaviorthe second tabstop in the list of the .ui file is the language and yet it takes 15 tabs to get there.Figured it out.
Closes #21387.